Fix JupyterLab widget filter traitlet
#1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue in the JupyterLab
PerspectiveWidgetPython classfiltertraitlet, which was set tofiltersin this class alone, causing the property to be mis-parsed on the client. Though this API changed in1.0.0(or rather, where the API previously allowed either, onlyfilteris now accepted), this is not technically a breaking change as it never worked in a release version after this (and there has been no release versions). Even the docs for e.g. the class's constructor refer to this kwarg asfilter. Hence, I won't mark thisbreakingand will only become a minor perspective release - but worth noting this is still "breaking" in that pre1.0.0code still won't work without a rename.I can't believe I have to add this, but please do not contact Perspective contributors with bug reports on their personal emails, cell phones, etc! Use Github Issues to open a short report, it takes minutes.