Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar Rendering bug null sends fix #1569

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Bar Rendering bug null sends fix #1569

merged 1 commit into from
Oct 16, 2021

Conversation

mattcolozzo
Copy link
Contributor

@mattcolozzo mattcolozzo commented Oct 6, 2021

fixed bar series bug where nulls were being sent to autoBandwidth causing bars to be rendered with inconsistent widths

@finos-cla-bot
Copy link

finos-cla-bot bot commented Oct 6, 2021

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : V726942

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email [email protected]
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email [email protected] so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

@mattcolozzo mattcolozzo changed the title WIP Bar Rendering bug null sends fix Oct 6, 2021
@texodus texodus force-pushed the bar-rendering branch 2 times, most recently from 3f713a3 to c6555d4 Compare October 6, 2021 16:59
@finos finos deleted a comment from finos-cla-bot bot Oct 6, 2021
@finos finos deleted a comment from finos-cla-bot bot Oct 6, 2021
@texodus texodus marked this pull request as ready for review October 13, 2021 15:45
@finos-cla-bot
Copy link

finos-cla-bot bot commented Oct 16, 2021

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@mattcolozzo).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email [email protected] for any questions.

cc @maoo @agitana @mcleo-d

@texodus
Copy link
Member

texodus commented Oct 16, 2021

Looks good! Thanks for the PR!

@texodus texodus merged commit ea24d72 into master Oct 16, 2021
@texodus texodus deleted the bar-rendering branch October 16, 2021 20:15
@texodus texodus linked an issue Oct 24, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacked bar widths are calculated incorrectly when passed null values
2 participants