Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1562, fix regressions in PerspectiveWidget #1565

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Fix #1562, fix regressions in PerspectiveWidget #1565

merged 1 commit into from
Oct 6, 2021

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Sep 30, 2021

This PR fixes some issues with PerspectiveWidget:

  • Updates were broken in the RC release but are now working
  • Client-server editing is now working again
  • Use one shared_worker for all widget instances, instead of a new worker per-instance
  • Update binder to 3.1.14, as Jupyterlab 3.0.x has a Webpack issue that causes a parse error when importing the Widget front-end.
  • Remove the MutationObserver on widget attributes as the attributes are no longer fixed on the front-end

As written in #1560, the goal for the widget is for a complete rewrite that cleans up both the Python and the JS side, and removes any dependency on traitlets. However, this PR fixes the regressions between the 1.0.0 RC release and our last release.

@sc1f sc1f added bug Concrete, reproducible bugs Jupyter labels Oct 4, 2021
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the PR!

@texodus texodus merged commit e02b7d6 into master Oct 6, 2021
@texodus texodus deleted the jlabfix branch October 6, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs Jupyter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants