Use TypeScript for @finos/perspective-viewer
#1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
correct-types
branch
from
90c1c80
to
9ae46b8
Compare
texodus
force-pushed
the
correct-types
branch
from
88b03fe
to
4e5bed7
Compare
texodus
force-pushed
the
correct-types
branch
from
4e5bed7
to
f7f6097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining an
index.d.tsfor Perspective has been a headache. As most development is now in Rust/WebAssembly anyway, and we only need shallow JavaScript wrappers to export clean APIs, we might as well write these wrappers in TypeScript to take advantage of the TypeScript compiler and the existing partial type signatures generated fromwasm_bindgenin Rust. I find this preferable to any combination of hand-writing type files and/or writing tests explicitly against type signatures (though we'll likely need some facsimile of the latter regardless).Additionally:
@finos/perspective.mobile-drag-dropintomobile-drag-drop-shadow-dom.