Fixes #1340 - removes dependency on removed ipywidgets API #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
ipywidgets.Widget.on_displayedfromPerspectiveWidget, which makesPerspectiveWidgetcompatible with ipywidget >= 8.0.0.This API was originally used for an esoteric feature: on the widget, in client mode, if the user called
widget.updatebefore the widget was displayed, the updates were not cached and thus silently dropped. Since the first releases ofperspective-python, we've tremendously cleaned up our build process and now offer wheels for all platforms, which should make client mode rarely used, if at all. Thus, this feature is slated for removal to maintain our compatibility with future ipywidgets versions.