Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benchmarks and remove versions pre 0.5.0 from benchmarking #1436

Merged
merged 3 commits into from
Jun 1, 2021
Merged

Fix benchmarks and remove versions pre 0.5.0 from benchmarking #1436

merged 3 commits into from
Jun 1, 2021

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Jun 1, 2021

This PR fixes the currently broken benchmark suite:

  • Remove versions before 0.5.0 from benchmarks, as the benchmarking results between such large version bounds is uninformative and maintenance of code that calls deprecated APIs makes the benchmarking code unwieldy and hard to read.
  • Re-enables expression column tests, and fixes the broken expressions that prevented certain tests from running/created errors
  • Fixes benchmark suite errors

@sc1f sc1f requested a review from texodus June 1, 2021 13:36
@sc1f sc1f added enhancement Feature requests or improvements JS internal Internal refactoring and code quality improvement and removed enhancement Feature requests or improvements labels Jun 1, 2021
texodus
texodus approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the PR!

@texodus texodus merged commit c99582d into master Jun 1, 2021
@texodus texodus deleted the refactor-benchmarks branch June 1, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc1f @texodus