Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some light sdist tests and upload sdist in CI #1433

Merged
merged 5 commits into from
Sep 21, 2021

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented May 28, 2021

Adding another azure pipeline to product a clean, pypi-publishable sdist on each build (but especially on the tagged release builds).

azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
python/perspective/scripts/build_sdist.sh Show resolved Hide resolved
@texodus texodus added internal Internal refactoring and code quality improvement Python labels May 28, 2021
@texodus texodus added this to the 0.9.0 milestone May 28, 2021
@texodus texodus marked this pull request as draft June 9, 2021 05:41
@finos finos deleted a comment from texodus Sep 20, 2021
@finos finos deleted a comment from texodus Sep 20, 2021
@finos finos deleted a comment from texodus Sep 20, 2021
adjust path

chmod

add artifact name

env vars not available from bash inline

move to linux

better name

compatible name

bump linux ver

tweak var, comment out other jobs for now

tweak var

get source branch from build var

revert to prior reference style

dont quote

Tweak variable reference

Try another way

more tweaks

more trimming

tweak naming

Revert name changes in file

see if this works

last tweak
@timkpaine
Copy link
Member Author

Produces a folder perspective-python-<branch/build ID> with the (fully independent build-tested) sdist.

Screen Shot 2021-09-20 at 10 17 27 PM

@timkpaine timkpaine marked this pull request as ready for review September 21, 2021 02:18
@texodus texodus merged commit 980ed2d into finos:master Sep 21, 2021
@texodus
Copy link
Member

texodus commented Sep 21, 2021

Looks good! Thanks for the PR!

texodus added a commit that referenced this pull request Sep 25, 2021
This reverts commit 980ed2d, reversing
changes made to 5a6d0cf.
texodus added a commit that referenced this pull request Sep 26, 2021
This reverts commit 980ed2d, reversing
changes made to 5a6d0cf.
texodus added a commit that referenced this pull request Sep 26, 2021
This reverts commit 980ed2d, reversing
changes made to 5a6d0cf.
texodus added a commit that referenced this pull request Sep 26, 2021
This reverts commit 980ed2d, reversing
changes made to 5a6d0cf.
@texodus texodus mentioned this pull request Sep 26, 2021
@timkpaine timkpaine deleted the cisdist branch December 11, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants