Smart column selection when switching visualization plugin #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
pushed a commit
that referenced
this pull request
Apr 7, 2019
* Refactor axis to use a common implementation for x and y Refactor to group by type of axis (linear/time/ordinal) rather than by direction. Use a common implementation for each chart for creating an axis, based on the settings and data it will be working from. Allow for aggregates that are strings turned into numbers (e.g. `count`) or left as string (e.g. `dominant`) * Allow charts to say which axis types they can't use * Applied new axis types to other charts * Rename files * Refactor `labelFunction` and remove `crossAxis` * Fix variances in screenshot tests * Restore heatmap vertical gridline * Exclude "linear" ranges from various charts * Default padding for chart axis, which can be overridden * Restore label rotation/hiding code that was lost in merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.