Replace emsdk-npm with simple script
#1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
emsdk-npmfork with an inlined script of the same nature, only this one installs Emscripten under the Project root's.emsdkdirectory, rather than deep withinnode_moduleswhere it is removed on every install. It also conveniently fixes a regression in this module, which even surreptitious amendment to the already-forkedemsdk-npmfailed to fix due to ... mystery reasons. Azure reports the cache miss, but then continues using the removed flag, and frankly I've just lost the will to determine why.