Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SplitPanel and port to Yew #1326

Merged
merged 1 commit into from
Feb 21, 2021
Merged

Add SplitPanel and port to Yew #1326

merged 1 commit into from
Feb 21, 2021

Conversation

texodus
Copy link
Member

@texodus texodus commented Feb 16, 2021

Extends the work started in #1314 with further integration/replacement into @finos/perspective-viewer.

  • New custom element <perspective-vieux> sits at the top level of a <perspective-viewer>'s Shadow Dom, and will eventually supplant its parent when all features have been ported.
  • StatusBarElement has been ported to Yew, a react-like Rust framework.
  • Further implemented sub-element StatusBarCounter, as well as PerspectiveVieux and SplitPanel.
  • Refactor embedded state changes to a new Session struct, which will own the Table and View instances and their associated state.
  • New unit and integration tests for all components.

@texodus texodus force-pushed the vieux-deux branch 5 times, most recently from e8ce53a to 7dc62a7 Compare February 20, 2021 18:44
@texodus texodus marked this pull request as ready for review February 21, 2021 03:50
@texodus texodus changed the title perspective-vieux pt. 2 Add SplitPanel and port to Yew Feb 21, 2021
@texodus texodus added the internal Internal refactoring and code quality improvement label Feb 21, 2021
@texodus texodus added this to the 0.7.0 milestone Feb 21, 2021
@texodus texodus merged commit 3bc672b into master Feb 21, 2021
@timkpaine timkpaine deleted the vieux-deux branch October 13, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant