Fix for layout jitter in the Column Selector #1318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a CSS cleanup/refactor of
@finos/perspective-viewer
's Column Selector widget, which aims to eliminate "jitter" in the widget's dimensions and layout as columns are activated or the container's size is changed. The responsive logic which divides this column into "active column list", "inactive column list" and "new column widget" sections does a pretty good job of intelligently using the available space, but has bugs. In this Before GIF, notice thatAfter GIF:
In this Before GIF, when a column is dragged-over a column-accepting input, the input shrinks and drags the rest of the flex container with it.
After GIF:
In this Before GIF, when the "Column Name" column is dragged into the Active Column list, the list expands by 5px forcing the datagrid to the right:
After GIF: