Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for layout jitter in the Column Selector #1318

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

texodus
Copy link
Member

@texodus texodus commented Feb 5, 2021

This is a CSS cleanup/refactor of @finos/perspective-viewer's Column Selector widget, which aims to eliminate "jitter" in the widget's dimensions and layout as columns are activated or the container's size is changed. The responsive logic which divides this column into "active column list", "inactive column list" and "new column widget" sections does a pretty good job of intelligently using the available space, but has bugs. In this Before GIF, notice that

  • The "New Column" dialog moves down when opened.
  • When the first column is deselected, the entire panel becomes slightly wider.
  • .. and also the "New Column" editor drops to the bottom of the container (off camera).
  • As each column is deselected, the "deselected" columns list creeps upwards by ~1-2px.
  • When closed, the "New Column" dialog is in a different place in relation to the bottom of the previous panel than when there were no columns deselected.

old

After GIF:

new

In this Before GIF, when a column is dragged-over a column-accepting input, the input shrinks and drags the rest of the flex container with it.

old2

After GIF:

new2

In this Before GIF, when the "Column Name" column is dragged into the Active Column list, the list expands by 5px forcing the datagrid to the right:

old3

After GIF:

new3

@texodus texodus added bug Concrete, reproducible bugs JS labels Feb 5, 2021
@texodus texodus added this to the 0.6.1 milestone Feb 5, 2021
Copy link
Contributor

@sc1f sc1f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down locally - looks good!

@texodus texodus merged commit 8982620 into master Feb 5, 2021
@texodus texodus deleted the column-selector-refactor branch February 5, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants