Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JupyterLab update to ^3.0.0, and fix "Open With.." regression #1294

Merged
merged 6 commits into from
Jan 19, 2021
Merged

JupyterLab update to ^3.0.0, and fix "Open With.." regression #1294

merged 6 commits into from
Jan 19, 2021

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Jan 17, 2021 •
edited
Loading

  • Bump supported JupyterLab version from 2. to 3.
  • Add .arrow renderer (in addition to .csv, .json, and .jsonl)
  • eslint the typescript

@texodus texodus linked an issue Jan 17, 2021 that may be closed by this pull request
Bump JupyterLab support for 3.0 now that it is released #1269
Closed
@texodus texodus added internal Internal refactoring and code quality improvement Jupyter Python labels Jan 17, 2021
@timkpaine
Copy link
Member Author

timkpaine commented Jan 17, 2021 •
edited
Loading

@texodus did you make web pack changes? we have a regression and are hitting this error again.

https://dev.azure.com/finosfoundation/perspective/_build/results?buildId=1947&view=logs&jobId=430750e5-873f-5cdb-f7d1-334fffa69fc8&j=430750e5-873f-5cdb-f7d1-334fffa69fc8&t=e9a709ee-98dc-5d78-ab76-09541ac9f110

@timkpaine
Copy link
Member Author

I can only seem to get around it with // ts-ignore

@timkpaine timkpaine mentioned this pull request Jan 18, 2021
Closed
@timkpaine timkpaine marked this pull request as ready for review January 18, 2021 02:32
@timkpaine
Copy link
Member Author

has some issues with the renderers, wait to merge

@timkpaine
Copy link
Member Author

looks like this PR broke everything #1231

@timkpaine
Copy link
Member Author

All set, load up csv, json, or now arrow from disk!

tmp

texodus
texodus requested changes Jan 19, 2021
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The new feature is cool but I'd like to see the PerspectiveViewer TypeScript API fixed to match the <perspective-viewer> API.

Again, a test or at least description of the actual broken case would really help. It would prevent regressions as #1296 and, respectfully, it is difficult to understand from the info provided if this is fix for a bug, or a personal preference.

packages/perspective-jupyterlab/src/ts/plugin.ts Show resolved Hide resolved
packages/perspective-jupyterlab/src/ts/psp_widget.ts Outdated Show resolved Hide resolved
packages/perspective-jupyterlab/src/ts/psp_widget.ts Outdated Show resolved Hide resolved
packages/perspective-jupyterlab/src/ts/renderer.ts Show resolved Hide resolved
@texodus texodus linked an issue Jan 19, 2021 that may be closed by this pull request
Typescript no longer being linted #1295
Closed
@texodus texodus changed the title starting on jlab3 JupyterLab update to ^3.0.0, and "Open With.." support Jan 19, 2021
@timkpaine timkpaine changed the title JupyterLab update to ^3.0.0, and "Open With.." support JupyterLab update to ^3.0.0, and fix "Open With.." support Jan 19, 2021
@timkpaine timkpaine changed the title JupyterLab update to ^3.0.0, and fix "Open With.." support JupyterLab update to ^3.0.0, and fix "Open With.." regression Jan 19, 2021
@timkpaine timkpaine mentioned this pull request Jan 19, 2021
Closed
@sc1f sc1f mentioned this pull request Jan 19, 2021
Merged
4 tasks
@texodus texodus added the 0.6.1 label Jan 19, 2021
texodus
texodus approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@texodus texodus merged commit a2c1e12 into master Jan 19, 2021
@texodus texodus deleted the jlab3 branch January 19, 2021 22:58
@sc1f sc1f mentioned this pull request Jan 20, 2021
Closed
@texodus texodus removed the 0.6.1 label Jan 30, 2021
@texodus texodus added this to the 0.6.1 milestone Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement Jupyter Python
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.

Typescript no longer being linted Bump JupyterLab support for 3.0 now that it is released
2 participants
@timkpaine @texodus