Fix #1213 - improve render warning behavior #1249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1213 by improving the behavior of
perspective-viewer
's render warnings, which display when the chart is attempting to render a dataset that is larger than specified bounds and might have performance implications.As outlined in #1213, render warnings would keep popping up even after a user has dismissed them, and it becomes an annoyance for the user. Additionally, the presence of the "Close" button allows there to be a state where the user has closed the warning that a subset of the data is being displayed, but if the viewer's config is not changed then there are no other indications that the user is looking at a subset of the data and not the whole.
This PR changes the behavior of the render warning in the following ways:
render_warning
option has been added to each plugin config, which allows the user to specify whether the warning should be shown at all (defaults totrue
):perspective-viewer-d3fc
.