fix for virtualenvs/envs with multiple py3 installed, allow for up to arrow 0.17 #1163
Conversation
cmake/modules/FindPyArrow.cmake
Outdated
| else() | ||
| find_package( PythonInterp 3.7 REQUIRED ) | ||
| find_package( PythonInterp REQUIRED ) | ||
| set(__numpy_out 1) |
There was a problem hiding this comment.
you see this little bug too?
There was a problem hiding this comment.
we were checking __pyarrow_out but re-setting __numpy_out
There was a problem hiding this comment.
where does __numpy_out get used? I couldn't find anything in our codebase
There was a problem hiding this comment.
timkpaine
changed the title
There was a problem hiding this comment.
Looks good. Tested locally with a Python 3.7 virtualenv and all paths are correct.
One caveat unrelated to the content of this fix - users should use virtualenv as venv (at least in my local installation) did not provide python3.7, and we use the exact version as our interpreter path. virtualenv fixed this problem for me though, and I'm not sure if it's just an issue on my machine but worth making a note here.
…verrideable by user or via pip install --no-build-isolation)
This reverts commit 5246699.
|
Thanks for the PR! |
fixes #1162, may also fix #1160 #1120 #1111 #1108 #937 #928