Updated development.md to show correct Emscripten version. #1138
Conversation
Changed the Emscripten version in the developer guide markdown (development.md) from 1.38.47 to 1.39.13. Updated the version number for reference and the script used to install the Emscripten SDK. Related to issue finos#1121 .
|
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement. Having reviewed our contributor list, we require a CLA for the following people : (@morgannavarro). If you need help obtaining a CLA, please read the Requirements for Contributions section of our CLA wiki or email [email protected] with your questions. Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. cc @finos-admin |
There was a problem hiding this comment.
Look good!
It would be awesome if pinning this version was not necessary, but alas upgrading Emscripten is basically guaranteed to break the build in a new, fun, obscure way. Maybe we should consider providing the emscripten installer as part of perspective's postinstall hook instead ...
Changed the Emscripten version in the developer guide markdown (development.md) from 1.38.47 to 1.39.13. Updated the version number for reference and the script used to install the Emscripten SDK. Closes #1121.