Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify python build #1118

Closed
wants to merge 32 commits into from
Closed

Simplify python build #1118

wants to merge 32 commits into from

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Jul 10, 2020

This PR seeks to replace the CMake build system with vanilla distutils for python.

Benefits

  • Much more portable than before
  • Vendored the header-only dependencies so no outside fetches at build time
    • boost no longer required as a system dependency
    • cmake no longer required as a system dependency
  • Should support conda on all platforms "out of the box"

Negatives

  • Slower builds potentially (using a numpy hack to have parallel builds)
  • No modification tracking (must recompile all files every time)
    • Can work around this for our day-to-day development with ccache
  • tbb required as a system dependency

@timkpaine timkpaine added internal Internal refactoring and code quality improvement Python labels Jul 10, 2020
@texodus
Copy link
Member

texodus commented Oct 4, 2020

Thanks for the PR! I think this patch has been overtaken by #1207 so I will close for now - feel free to re-open if I've missed something or this is ready for review.

@texodus texodus closed this Oct 4, 2020
@texodus texodus deleted the simplify_python_build branch January 30, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants