Explicitly floor start row/col and ceil end row/col #1112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents
to_format
from being called with float start/end row and column indices, and unifies behavior across Javascript and Python bindings. This fixes an issue withperspective-datagrid
where float start/end row indices were being sent to aperspective-python
Table, and rejected by a C++ function whose parameters were integers.For
start_row
andstart_col
,floor
is called - so requesting a start row of0.3
would start at0
, and not at1
. Forend_row
andend_col
,ceil
is called so that an end row of1.2
would return2
, and not 1. This means that the data window should never be smaller than requested by the plugin.