Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribute labextension, enable classic notebook #1063

Closed
wants to merge 16 commits into from
Closed

Distribute labextension, enable classic notebook #1063

wants to merge 16 commits into from

Conversation

timkpaine
Copy link
Member

This PR does a few things:

  • distribute the labextension inside the python package, which removes the need for a separate jupyter labextension install @finos/perspective-jupyterlab step
  • enable the classic notebook extension, and distribute the assets as well
  • ensure the presence of the JS assets during sdist/bdist

@timkpaine timkpaine added the enhancement Feature requests or improvements label May 24, 2020
@texodus
Copy link
Member

texodus commented Oct 4, 2020

Thanks for the PR! Since this has bitrotted badly ... I'm going to go ahead and close it. Feel free to re-open when this is ready for a review.

@texodus texodus closed this Oct 4, 2020
@timkpaine timkpaine mentioned this pull request Nov 17, 2020
Closed
@texodus texodus deleted the nbextension branch January 30, 2021 22:42
@texodus texodus restored the nbextension branch February 12, 2021 18:43
@timkpaine timkpaine deleted the nbextension branch May 8, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Feature requests or improvements JS Jupyter Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timkpaine @texodus @finos-admin