Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull JupyterLab widget version from package.json #423

Closed
timkpaine opened this issue Feb 7, 2019 · 1 comment
Closed

Pull JupyterLab widget version from package.json #423

timkpaine opened this issue Feb 7, 2019 · 1 comment
Assignees
@timkpaine
Labels
JS Jupyter

Comments

@timkpaine
Copy link
Member

https://github.com/jpmorganchase/perspective/blob/master/packages/perspective-jupyterlab/src/ts/version.ts#L11

should come from

https://github.com/jpmorganchase/perspective/blob/master/packages/perspective-jupyterlab/package.json#L3
@timkpaine
Copy link
Member Author

Apparently this is required for voila:
Screen Shot 2019-03-08 at 4 11 37 PM

@timkpaine timkpaine self-assigned this Mar 9, 2019
@texodus texodus closed this as completed in 9cff6a4 Mar 9, 2019
texodus added a commit that referenced this issue Mar 9, 2019
@texodus
Merge pull request #481 from jpmorganchase/get_version_from_package_json
726df9f 
Get version from package json: fixes #423
matt-hooper pushed a commit to redbearsam/perspective that referenced this issue Mar 18, 2019
@matt-hooper
fixes finos#423
9547f6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timkpaine timkpaine

Labels
JS Jupyter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@texodus @timkpaine