Don't allow multiple-parameter computed columns with missing columns

finos · Sep 3, 2018 · fdedf8a · fdedf8a
1 parent d2065eb
commit fdedf8a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/perspective-viewer/src/js/computed_column.js b/packages/perspective-viewer/src/js/computed_column.js
@@ -331,7 +331,9 @@ class ComputedColumn extends HTMLElement {
         }
 
         this.state['input_columns'] = inputs;
-        this._auto_column_name();
+        if (inputs.length === computation.num_params) {
+            this._auto_column_name();
+        }
 
         this.dispatchEvent(new CustomEvent('perspective-computed-column-update', {
             detail: {

diff --git a/packages/perspective-viewer/src/js/computed_column/State.js b/packages/perspective-viewer/src/js/computed_column/State.js
@@ -25,6 +25,6 @@ export default class State {
 
     is_valid() {
         const vals = values(this);
-        return !vals.includes(null) && !vals.includes(undefined) && !vals.includes('');
+        return !vals.includes(null) && !vals.includes(undefined) && !vals.includes('') && this.input_columns.length === this.computation.num_params;
     }
 }