Fix bug in perspective-toggle-config event dispatch order.

packages/perspective-viewer-d3fc/test/results/linux.docker.json

@@ -1,7 +1,7 @@
 {
     "candlestick_filter_by_a_single_instrument_": "f988ca6494d7a36bada09928cd1a544e",
     "candlestick_filter_to_date_range_": "8ee3e99ad9716a408252cf5e23895d28",
-    "__GIT_COMMIT__": "166393207a0d9de6bfce5afc326f5ac495d71b6a",
+    "__GIT_COMMIT__": "5a4327948f6de20d350eaa24c8910c5e5dbb640e",
     "ohlc_filter_by_a_single_instrument_": "0110fac1f2befac1b97a9d33f0022acf",
     "ohlc_filter_to_date_range_": "1254db69f0f5260c5a99af5486bd5615",
     "scatter_shows_a_grid_without_any_settings_applied_": "8677946ab48f16a376c421500d59e6c0",

packages/perspective-viewer-highcharts/test/results/linux.docker.json

@@ -25,7 +25,7 @@
     "render_warning_render_warning_should_show_above_size_limit_": "fec978469e044f80d32cc62db3d50c8e",
     "render_warning_dismissing_render_warning_should_trigger_render_": "f048923ce813618c0a45e8d3c91f9243",
     "render_warning_underlying_data_updates_should_not_trigger_rerender_if_warning_is_visible_": "e86356a4da01449f592933db1f6c98ec",
-    "__GIT_COMMIT__": "166393207a0d9de6bfce5afc326f5ac495d71b6a",
+    "__GIT_COMMIT__": "5a4327948f6de20d350eaa24c8910c5e5dbb640e",
     "line_shows_a_grid_without_any_settings_applied_": "daa48e26ee315f01377eaaf054088934",
     "line_pivots_by_a_row_": "58cf884c20144abf0bef9213369e2b4f",
     "line_pivots_by_two_rows_": "7383fffaf8cbf886090e501a658ef4e2",
@@ -41,7 +41,7 @@
     "line_displays_visible_columns_": "a451e28f589cc3d436071744693d1bf2",
     "line_axis_tests_sets_a_category_X_axis_when_pivoted_by_a_datetime_": "25f926cf75a93b7f2e10be7b550f4e09",
     "line_axis_tests_sets_a_category_axis_when_the_axis_type_is_a_string_": "b633ff56439c041e79172eee72dddf75",
-    "line_tooltip_tests_tooltip_shows_on_hover_": "e083e6845d062209664f185319ac4676",
+    "line_tooltip_tests_tooltip_shows_on_hover_": "29b6fb52d6148b19c4c99062fe6df62d",
     "line_tooltip_tests_tooltip_shows_pivot_labels_": "981a177ef625dd422e934b99f150af3a",
     "scatter_shows_a_grid_without_any_settings_applied_": "2e5ab01698615779dbe3f70e9fdf19a3",
     "scatter_pivots_by_a_row_": "b60fbf9dce9a3cd47e8029a708845f72",
@@ -58,7 +58,7 @@
     "scatter_displays_visible_columns_": "5310a94f28417f9ed65a487742be6c96",
     "scatter_axis_tests_sets_a_category_X_axis_when_pivoted_by_a_datetime_": "7945fbd06a5b2e07e45cdf403b8c1877",
     "scatter_axis_tests_sets_a_category_axis_when_the_axis_type_is_a_string_": "fc600d174597a36c2dadea1a8d1e41cc",
-    "scatter_tooltip_tests_tooltip_shows_on_hover_": "666d90de118bcdc3c84c333e20c2cc66",
+    "scatter_tooltip_tests_tooltip_shows_on_hover_": "fcc95b2cd17bcdd02f5d915359e25039",
     "scatter_tooltip_tests_tooltip_shows_pivot_labels_": "074c6b2c914ad18fd7d88150b459a768",
     "treemap_shows_a_grid_without_any_settings_applied_": "e61a53b560304cfbe3a6464218910cb0",
     "treemap_pivots_by_a_row_": "f4dead09e192212907944d861723521f",

packages/perspective-viewer-hypergrid/test/results/linux.docker.json

@@ -6,11 +6,11 @@
     "superstore_pivots_by_a_row_and_a_column_": "155d4395ddc94a79d2d54919c441bbc4",
     "superstore_pivots_by_two_rows_and_two_columns_": "7db1b9844bf498ad79c80ac4d738fbd3",
     "superstore_sorts_by_a_hidden_column_": "fb72c4ff5a5b5826f5cc64a5ca69de6f",
-    "superstore_sorts_by_a_numeric_column_": "d048dc0cec2fa57591f806853bc58606",
+    "superstore_sorts_by_a_numeric_column_": "2fb8bf1881fda3676d736287628e0076",
     "superstore_filters_by_a_numeric_column_": "0ee643e68b4241460595f9bcced7376f",
     "superstore_filters_by_a_datetime_column_": "be6925c9d107eb8bcae3aba6880fbc35",
-    "superstore_highlights_invalid_filter_": "03965ee5cb0c9a5e30fb4c4b7425040c",
-    "superstore_sorts_by_an_alpha_column_": "8e07d41a34f60c15fc824b1082390ce8",
+    "superstore_highlights_invalid_filter_": "94356ffb2c8edfe4b4ad874e5e989b09",
+    "superstore_sorts_by_an_alpha_column_": "1514d90a40e191c2918a18e0a80781a6",
     "superstore_displays_visible_columns_": "ee7fc22393f07274b4ec11f633ca7870",
     "superstore_expand/collapse_should_not_be_able_to_expand_past_number_of_row_pivots": "a83840c200e8e71ec5051a53b0a7f8ef",
     "superstore_expand/collapse_collapses_to_depth_smaller_than_viewport": "7b1c805ec9d08fc3dba4d0f72c1230b6",
@@ -26,13 +26,13 @@
     "superstore_memoized_column_meta_should_reinterpret_metadata_when_only_row_pivots_are_changed": "ec6807a695b5693a2ed592d5aed583db",
     "superstore_resets_viewable_area_when_the_logical_size_expands_": "82f08a672fd31199031673b79bf8625d",
     "superstore_resets_viewable_area_when_the_physical_size_expands_": "13d3164f406bf6a7d053c21dd506a0d5",
-    "__GIT_COMMIT__": "166393207a0d9de6bfce5afc326f5ac495d71b6a",
+    "__GIT_COMMIT__": "5a4327948f6de20d350eaa24c8910c5e5dbb640e",
     "empty_perspective-click_is_fired_when_an_empty_dataset_is_loaded_first": "7e5b653226145e1ab9f82e2417d89d7b",
     "hypergrid_clicking_on_a_cell_in_the_grid_when_no_filters_are_present_perspective_dispatches_perspective-click_event_with_correct_properties_": "13d3164f406bf6a7d053c21dd506a0d5",
     "hypergrid_clicking_on_a_cell_in_the_grid_when_a_filter_is_present_perspective_dispatches_perspective-click_event_with_one_filter_": "b66684328af5084134b0d3ed8d095eaf",
     "hypergrid_clicking_on_a_cell_in_the_grid_when_a_filter_is_present_perspective_dispatches_perspective-click_event_with_filters_": "44186397ec3d65a3390a0dbd80f08c76",
     "hypergrid_clicking_on_a_cell_in_the_grid_when_a_filter_is_present_perspective-click_event_with_column-pivots_clicking_on_the_row_header_": "44186397ec3d65a3390a0dbd80f08c76",
-    "superstore_editing_UI_opens_should_not_edit_an_immutable_viewer": "54eb64133beb416fac5ed681c6cc3e6a",
+    "superstore_editing_UI_opens_should_not_edit_an_immutable_viewer": "13bf4213e51aea91d91540a5c5b93f83",
     "editable_editing_UI_saves_should_save_edits_to_a_string_column": "78f1849035b3152ee3065f4412f5b286",
     "editable_editing_UI_saves_should_save_edits_to_an_integer_column": "4d230ccf937d2697094b835bf1411e3a",
     "editable_editing_UI_saves_should_save_edits_of_negative_numbers_to_an_integer_column": "6dfeccf7a2c7b9143c0183ee82cf28d2",
@@ -46,5 +46,5 @@
     "regressions_Updates_should_not_render_an_extra_row_for_column_only_views": "f2c61f5fa18572dc7d36a8f918ad61ed",
     "regressions_Updates_regular_updates": "c519987a2a2179eb5b50fbcd99c87a95",
     "regressions_Updates_saving_a_computed_column_does_not_interrupt_update_rendering": "5b94b47e26123842e366c31c0dd2ae43",
-    "superstore_replaces_all_rows_": "ed6f3cb7c65a3b5dfae8be54bf672b84"
+    "superstore_replaces_all_rows_": "9cd0751b14f8ba6c857bf9b92f1d366b"
 }

packages/perspective-viewer/src/js/viewer/action_element.js

@@ -35,18 +35,20 @@ export class ActionElement extends DomElement {
                     () => {
                         this._side_panel.style.display = "none";
                         this._top_panel.style.display = "none";
-                        this.toggleAttribute("settings", true);
+                        this.removeAttribute("settings");
                     },
                     () => this.dispatchEvent(new CustomEvent("perspective-toggle-settings", {detail: this._show_config}))
                 );
             } else {
                 await this._post_resize(
                     () => {
-                        this._side_panel.style.display = "flex";
-                        this._top_panel.style.display = "flex";
                         this.toggleAttribute("settings", true);
                     },
-                    () => this.dispatchEvent(new CustomEvent("perspective-toggle-settings", {detail: this._show_config}))
+                    () => {
+                        this._side_panel.style.display = "flex";
+                        this._top_panel.style.display = "flex";
+                        this.dispatchEvent(new CustomEvent("perspective-toggle-settings", {detail: this._show_config}));
+                    }
                 );
             }
         }

packages/perspective-viewer/test/results/linux.docker.json

@@ -13,7 +13,7 @@
     "superstore_filters_by_computed_column_": "fa0fbf6eeec33053a30700c73dc75520",
     "superstore_computed_column_aggregates_should_persist_": "a7030a052356ed393cc4fe9c5f03c422",
     "superstore_user_defined_aggregates_maintained_on_computed_columns": "b6309eb8a6883114e424a3e350bb18e0",
-    "__GIT_COMMIT__": "166393207a0d9de6bfce5afc326f5ac495d71b6a",
+    "__GIT_COMMIT__": "5a4327948f6de20d350eaa24c8910c5e5dbb640e",
     "blank_Handles_reloading_with_a_schema_": "f6c016d83aeb20b04f8eecb73f0e40f5",
     "superstore_doesn_t_leak_tables_": "8974cdec585553e7011b54b4867b5072",
     "superstore_doesn_t_leak_elements_": "8974cdec585553e7011b54b4867b5072",

packages/perspective-workspace/test/results/linux.docker.json

@@ -2,7 +2,7 @@
     "index_restore_workspace_with_detail_only": "1168e9bee0eec492dfd5f50b2e087d84",
     "index_restore_workspace_with_master_only": "17241c83a4c438b3da9ab1860fd2b1b6",
     "index_restore_workspace_with_master_and_detail": "564f405f5a2185a71b514afd132a1ea0",
-    "__GIT_COMMIT__": "166393207a0d9de6bfce5afc326f5ac495d71b6a",
+    "__GIT_COMMIT__": "5a4327948f6de20d350eaa24c8910c5e5dbb640e",
     "index_HTML_Create_One": "f3cc4b8096b69679e85526ccf28120a6",
     "index_HTML_Create_Multiple": "67d5318f2bb18b0cfd7130e72199dd52",
     "index_HTML_Create_multiple_with_names": "0bed0974e891d51eb400070f99f78189",