Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage minimal graph to build query builder with datsapaces if and only if metadata returns qualified json #3642

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YannanGao-gs
Copy link
Contributor

@YannanGao-gs YannanGao-gs commented Nov 1, 2024

Summary

Leverage minimal graph to build query builder with datsapaces if and only if metadata returns qualified json

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@YannanGao-gs YannanGao-gs requested a review from a team as a code owner November 1, 2024 20:43
Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: b367ae5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application-query Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 45.48%. Comparing base (18e03b6) to head (b367ae5).

Files with missing lines Patch % Lines
...e/v1/V1_DSL_DataSpace_PureGraphManagerExtension.ts 5.88% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3642      +/-   ##
==========================================
- Coverage   45.61%   45.48%   -0.14%     
==========================================
  Files        2172     2172              
  Lines      376108   376077      -31     
  Branches    16191    10398    -5793     
==========================================
- Hits       171562   171040     -522     
- Misses     203800   204594     +794     
+ Partials      746      443     -303     
Files with missing lines Coverage Δ
...d-application-query/src/stores/QueryEditorStore.ts 55.13% <ø> (+0.02%) ⬆️
...ol/pure/DSL_DataSpace_PureGraphManagerExtension.ts 92.04% <ø> (-0.18%) ⬇️
...e/v1/V1_DSL_DataSpace_PureGraphManagerExtension.ts 14.66% <5.88%> (+0.40%) ⬆️

... and 192 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant