Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loading indicator in generating test data #2508

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

YannanGao-gs
Copy link
Contributor

@YannanGao-gs YannanGao-gs commented Aug 14, 2023

Summary

Fix the bug where the loading indicator of the service test editor is not showing up

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

before:

Screen.Recording.2023-08-14.at.12.51.24.PM.mov

after:

Screen.Recording.2023-08-14.at.12.50.01.PM.mov

@YannanGao-gs YannanGao-gs requested a review from a team as a code owner August 14, 2023 16:50
@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

🦋 Changeset detected

Latest commit: 46f5b95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@finos/legend-application-studio Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-manual-tests Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@YannanGao-gs YannanGao-gs self-assigned this Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #2508 (46f5b95) into master (14ccb1d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2508   +/-   ##
=======================================
  Coverage   41.59%   41.59%           
=======================================
  Files        1595     1595           
  Lines       75498    75498           
  Branches    17778    17778           
=======================================
+ Hits        31401    31403    +2     
+ Misses      43970    43968    -2     
  Partials      127      127           
Files Changed Coverage Δ
.../service-editor/testable/ServiceTestDataEditor.tsx 33.33% <100.00%> (+1.28%) ⬆️

@MauricioUyaguari MauricioUyaguari changed the title Fix the bug where the loading indicator of the service test editor is not showing up add loading indicator in generating test data Aug 14, 2023
@MauricioUyaguari MauricioUyaguari merged commit fb96d42 into finos:master Aug 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants