Support in filter operator for date primitive type #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fb53399 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gayathrir11
added
the
Component: Query Builder
Codecov Report
@@ Coverage Diff @@
## master #2489 +/- ##
==========================================
- Coverage 41.67% 41.60% -0.08%
==========================================
Files 1585 1593 +8
Lines 75060 75479 +419
Branches 17675 17782 +107
==========================================
+ Hits 31283 31401 +118
- Misses 43652 43951 +299
- Partials 125 127 +2
|
added 2 commits
August 9, 2023 19:42
MauricioUyaguari
approved these changes
Aug 15, 2023
| @@ -705,6 +771,8 @@ const CollectionValueInstanceValueEditor = observer( | |||
| setText(event.target.value); | |||
| }; | |||
|
|
|||
| const placeholder = text === '' ? getPlaceHolder(expectedType) : undefined; | |||
There was a problem hiding this comment.
i know it was here before but do we need the text === '' check. i think placeholder only shows when the input is empty regardless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?
video.mp4
Placeholder for date
