Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where failing to start filtering by current value after the column results are re-ordered #2483

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

YannanGao-gs
Copy link
Contributor

@YannanGao-gs YannanGao-gs commented Aug 4, 2023

Summary

Fix a bug where failing to start filtering by current value after the column results are re-ordered

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

before:

Screen.Recording.2023-08-09.at.10.46.46.AM.mov

after:

Screen.Recording.2023-08-09.at.10.39.25.AM.mov

@YannanGao-gs YannanGao-gs requested a review from a team as a code owner August 4, 2023 20:02
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

🦋 Changeset detected

Latest commit: 714b8c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@finos/legend-graph Patch
@finos/legend-query-builder Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-studio Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-lego Patch
@finos/legend-manual-tests Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@YannanGao-gs YannanGao-gs marked this pull request as draft August 4, 2023 20:08
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #2483 (714b8c2) into master (9c1815f) will decrease coverage by 0.01%.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##           master    #2483      +/-   ##
==========================================
- Coverage   41.63%   41.63%   -0.01%     
==========================================
  Files        1590     1590              
  Lines       75354    75370      +16     
  Branches    17745    17753       +8     
==========================================
+ Hits        31377    31382       +5     
- Misses      43852    43863      +11     
  Partials      125      125              
Files Changed Coverage Δ
...builder/src/components/QueryBuilderResultPanel.tsx 43.29% <25.00%> (-0.28%) ⬇️
.../graph-manager/action/execution/ExecutionResult.ts 9.37% <33.33%> (+9.37%) ⬆️

@akphi akphi merged commit 61ee843 into finos:master Aug 9, 2023
11 checks passed
@akphi akphi deleted the sort branch August 9, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants