Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support service with multi execution in Dataspace Quick Start #2445

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

YannanGao-gs
Copy link
Contributor

@YannanGao-gs YannanGao-gs commented Jul 20, 2023

Summary

Support service with multi execution in Dataspace Quick Start
Depends on finos/legend-engine#2054

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@YannanGao-gs YannanGao-gs requested a review from a team as a code owner July 20, 2023 15:54
@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2023

🦋 Changeset detected

Latest commit: b66273a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-manual-tests Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #2445 (b66273a) into master (c8381fc) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master    #2445      +/-   ##
==========================================
- Coverage   41.68%   41.67%   -0.02%     
==========================================
  Files        1584     1584              
  Lines       74804    74838      +34     
  Branches    17594    17597       +3     
==========================================
+ Hits        31183    31189       +6     
- Misses      43495    43523      +28     
  Partials      126      126              
Files Changed Coverage Δ
...-data-space/src/components/DataSpaceQuickStart.tsx 5.50% <0.00%> (-0.11%) ⬇️
...raph-manager/action/analytics/DataSpaceAnalysis.ts 3.22% <0.00%> (-0.23%) ⬇️
...e/v1/V1_DSL_DataSpace_PureGraphManagerExtension.ts 9.29% <6.25%> (-0.15%) ⬇️
...l/pure/v1/engine/analytics/V1_DataSpaceAnalysis.ts 26.04% <22.22%> (-0.47%) ⬇️
...-data-space/src/stores/DataSpaceQuickStartState.ts 21.05% <33.33%> (+8.55%) ⬆️

@YannanGao-gs YannanGao-gs force-pushed the quickStart branch 2 times, most recently from 9b6926c to b9b4988 Compare July 24, 2023 22:04
@YannanGao-gs YannanGao-gs self-assigned this Jul 25, 2023
@YannanGao-gs YannanGao-gs force-pushed the quickStart branch 2 times, most recently from ad530c3 to 49f34f6 Compare July 25, 2023 19:15
@YannanGao-gs YannanGao-gs added the Status: Waiting for Backend Change The PR should not be merged if the changes in the backend has not been live yet label Jul 25, 2023
@akphi akphi merged commit 1e84302 into finos:master Aug 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for Backend Change The PR should not be merged if the changes in the backend has not been live yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants