Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query builder to support from expression #2417

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

MauricioUyaguari
Copy link
Member

@MauricioUyaguari MauricioUyaguari commented Jul 10, 2023

Summary

  • support editing from functions in query builder
  • edit compatible lambdas in function editor via embedded query builder

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023

🦋 Changeset detected

Latest commit: f64ccff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-application-studio Minor
@finos/legend-application-query Patch
@finos/legend-query-builder Minor
@finos/legend-graph Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-manual-tests Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-pure-ide Patch
@finos/legend-lego Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MauricioUyaguari MauricioUyaguari force-pushed the internalize branch 2 times, most recently from cc15d3b to 197febc Compare July 10, 2023 21:25
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #2417 (f64ccff) into master (2a729ba) will decrease coverage by 0.03%.
The diff coverage is 35.87%.

@@            Coverage Diff             @@
##           master    #2417      +/-   ##
==========================================
- Coverage   41.67%   41.65%   -0.03%     
==========================================
  Files        1585     1588       +3     
  Lines       75060    75226     +166     
  Branches    17675    17712      +37     
==========================================
+ Hits        31283    31336      +53     
- Misses      43652    43765     +113     
  Partials      125      125              
Files Changed Coverage Δ
.../components/editor/editor-group/FunctionEditor.tsx 11.71% <0.00%> (-0.95%) ⬇️
...ace/src/stores/query/DataSpaceQueryCreatorStore.ts 4.05% <ø> (ø)
...vice/src/components/query/ServiceRegisterModal.tsx 17.24% <0.00%> (ø)
...raph/src/graph-manager/AbstractPureGraphManager.ts 30.55% <ø> (ø)
...er/helpers/ValueSpecificationGraphManagerHelper.ts 12.50% <ø> (ø)
...ph-manager/protocol/pure/v1/V1_PureGraphManager.ts 45.38% <0.00%> (-0.09%) ⬇️
.../components/explorer/QueryBuilderExplorerPanel.tsx 83.09% <ø> (ø)
...r/src/components/workflows/ServiceQueryBuilder.tsx 7.89% <0.00%> (ø)
...builder/src/stores/QueryBuilderInternalizeState.ts 0.00% <0.00%> (ø)
...uery-builder/src/stores/QueryBuilderResultState.ts 56.25% <ø> (ø)
... and 25 more

... and 3 files with indirect coverage changes

@MauricioUyaguari MauricioUyaguari force-pushed the internalize branch 2 times, most recently from a01ebea to 172648c Compare July 11, 2023 14:23
@MauricioUyaguari MauricioUyaguari force-pushed the internalize branch 3 times, most recently from 88371d7 to bae8b56 Compare August 1, 2023 13:11
@MauricioUyaguari MauricioUyaguari changed the title x query builder to support from expression Aug 1, 2023
@MauricioUyaguari MauricioUyaguari force-pushed the internalize branch 5 times, most recently from 93501c2 to 4ba79ea Compare August 3, 2023 17:03
@MauricioUyaguari MauricioUyaguari marked this pull request as ready for review August 3, 2023 17:04
@MauricioUyaguari MauricioUyaguari requested a review from a team as a code owner August 3, 2023 17:04
@MauricioUyaguari MauricioUyaguari merged commit e788d13 into finos:master Aug 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants