Remove graph building form text mode

[gayathrir11]

Summary

Closes #966

How did you test this change?

• Test(s) added
• Manual testing (please provide screenshots/recordings)
• No testing (please provide an explanation)

[changeset-bot]

🦋 Changeset detected

Latest commit: 7f367da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages

Name	Type
@finos/legend-application-studio	Minor
@finos/legend-graph	Minor
@finos/legend-application-studio-bootstrap	Patch
@finos/legend-extension-dsl-data-space	Patch
@finos/legend-extension-dsl-diagram	Patch
@finos/legend-extension-dsl-mastery	Patch
@finos/legend-extension-dsl-persistence-cloud	Patch
@finos/legend-extension-dsl-persistence	Patch
@finos/legend-extension-dsl-service	Patch
@finos/legend-extension-dsl-text	Patch
@finos/legend-extension-format-morphir	Patch
@finos/legend-extension-store-flat-data	Patch
@finos/legend-extension-store-relational	Patch
@finos/legend-extension-store-service-store	Patch
@finos/legend-application-pure-ide	Patch
@finos/legend-application-query-bootstrap	Patch
@finos/legend-application-query	Patch
@finos/legend-application-taxonomy-bootstrap	Patch
@finos/legend-application-taxonomy	Patch
@finos/legend-application	Patch
@finos/legend-extension-format-json-schema	Patch
@finos/legend-manual-tests	Patch
@finos/legend-query-builder	Patch
@finos/legend-application-studio-deployment	Patch
@finos/legend-application-pure-ide-deployment	Patch
@finos/legend-application-query-deployment	Patch
@finos/legend-application-taxonomy-deployment	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Merging #1693 (7f367da) into master (59290dd) will decrease coverage by 0.13%.
The diff coverage is 12.10%.

@@            Coverage Diff             @@
##           master    #1693      +/-   ##
==========================================
- Coverage   40.52%   40.38%   -0.14%     
==========================================
  Files        1400     1400              
  Lines       62617    62915     +298     
  Branches    14618    14685      +67     
==========================================
+ Hits        25377    25411      +34     
- Misses      37139    37403     +264     
  Partials      101      101              

Impacted Files	Coverage Δ
...c/stores/editor-state/FileGenerationViewerState.ts	10.34% <0.00%> (-0.77%)	⬇️
...r-state/element-editor-state/ElementEditorState.ts	37.77% <0.00%> (-1.76%)	⬇️
...graph/src/graphManager/AbstractPureGraphManager.ts	40.00% <ø> (ø)
...aphManager/protocol/pure/v1/V1_PureGraphManager.ts	51.77% <3.33%> (-1.79%)	⬇️
...-application-studio/src/stores/EditorGraphState.ts	33.14% <9.09%> (-5.81%)	⬇️
...udio/src/stores/sidebar-state/LocalChangesState.ts	14.42% <10.89%> (-1.26%)	⬇️
...application-studio/src/stores/ExplorerTreeState.ts	60.81% <13.63%> (-6.97%)	⬇️
...ication-studio/src/stores/EditorTabManagerState.ts	42.55% <15.38%> (-10.23%)	⬇️
...lication-studio/src/stores/ChangeDetectionState.ts	63.70% <21.62%> (-7.39%)	⬇️
...egend-application-studio/src/stores/EditorStore.ts	49.08% <25.00%> (-0.66%)	⬇️
... and 1 more

[MauricioUyaguari]

half way through the changes will continue tomorrow

[MauricioUyaguari]

still got 2/3 more files to go over but I think im okay to merge and start testing. i will leave more comments tomorrow and you can address them in the other text mode PR you have up. Thanks

[MauricioUyaguari]

Here I think this is just because of current behaviour but i think now we can actually open a diff if they click on it and they are in text mode right?
Either ways if openChange only works for form mode, we should think about disabling the button or some kind of UI indiactor?

[gayathrir11]

I don't think they can open diff editor when they are in text mode. It just doesn't open anything. We can diable the button. That would be a good option. This reminds me we need to disable globalTestRunner too.
Will discuss more on that offline

[MauricioUyaguari]

more comments