Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Typescript ESM resolution mode #1190

Merged
merged 8 commits into from
Jun 2, 2022
Merged

Adopt Typescript ESM resolution mode #1190

merged 8 commits into from
Jun 2, 2022

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Jun 1, 2022

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Jun 1, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2022

🦋 Changeset detected

Latest commit: 7f6ac77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@finos/eslint-plugin-legend-studio Major
@finos/legend-application Major
@finos/legend-art Major
@finos/legend-dev-utils Major
@finos/legend-extension-dsl-data-space Major
@finos/legend-extension-dsl-diagram Major
@finos/legend-extension-dsl-persistence Major
@finos/legend-extension-dsl-text Major
@finos/legend-extension-external-format-json-schema Major
@finos/legend-extension-external-language-morphir Major
@finos/legend-extension-external-store-service Major
@finos/legend-extension-mapping-generation Major
@finos/legend-graph Major
@finos/legend-graph-extension-collection Major
@finos/legend-manual-tests Major
@finos/legend-model-storage Major
@finos/legend-query Major
@finos/legend-server-depot Major
@finos/legend-server-sdlc Major
@finos/legend-shared Major
@finos/legend-studio Major
@finos/legend-studio-extension-management-toolkit Major
@finos/legend-studio-extension-query-builder Major
@finos/legend-taxonomy Major
@finos/legend-tracer-extension-zipkin Major
@finos/legend-query-deployment Patch
@finos/legend-studio-deployment Patch
@finos/legend-taxonomy-deployment Patch
@finos/legend-query-app Patch
@finos/legend-studio-app Patch
@finos/legend-taxonomy-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1190 (7f6ac77) into master (353b505) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
+ Coverage   41.93%   41.95%   +0.01%     
==========================================
  Files        1138     1137       -1     
  Lines       50724    50716       -8     
  Branches    11622    11621       -1     
==========================================
+ Hits        21273    21277       +4     
+ Misses      29381    29369      -12     
  Partials       70       70              
Impacted Files Coverage Δ
packages/eslint-plugin/index.js 0.00% <0.00%> (ø)
packages/eslint-plugin/src/configs/recommended.js 0.00% <ø> (ø)
...ages/eslint-plugin/src/configs/scripts-override.js 0.00% <0.00%> (ø)
packages/eslint-plugin/src/index.js 0.00% <ø> (ø)
...-application/src/application/LegendApplication.tsx 8.00% <ø> (ø)
...src/application/LegendApplicationPluginManager.tsx 0.00% <ø> (ø)
.../legend-application/src/components/ActionAlert.tsx 9.30% <ø> (ø)
...cation/src/components/ApplicationStoreProvider.tsx 0.00% <ø> (ø)
...c/components/ApplicationStoreProviderTestUtils.tsx 0.00% <0.00%> (ø)
...n/src/components/BasicValueSpecificationEditor.tsx 12.29% <ø> (ø)
... and 216 more

@akphi akphi force-pushed the ki branch 7 times, most recently from 3dfffea to ef665dc Compare June 2, 2022 20:02
@akphi akphi marked this pull request as ready for review June 2, 2022 20:04
@akphi akphi changed the title more maintenance stuffs Adopt Typescript ESM resolution mode Jun 2, 2022
@akphi akphi merged commit 4c076c9 into finos:master Jun 2, 2022
@akphi akphi deleted the ki branch June 2, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Switch to ESM --moduleResolution node12 for Typescript
2 participants