generated from finos/software-project-blueprint
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt Typescript ESM
resolution mode
#1190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7f6ac77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1190 +/- ##
==========================================
+ Coverage 41.93% 41.95% +0.01%
==========================================
Files 1138 1137 -1
Lines 50724 50716 -8
Branches 11622 11621 -1
==========================================
+ Hits 21273 21277 +4
+ Misses 29381 29369 -12
Partials 70 70
|
akphi
force-pushed
the
ki
branch
7 times, most recently
from
June 2, 2022 20:02
3dfffea
to
ef665dc
Compare
4 tasks
MauricioUyaguari
approved these changes
Jun 2, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--moduleResolution node12
for Typescript #793finos/legend-shared-server
image inDockerfile
sjest-extended
typings in test files[email protected]
ESM module resolution strategy - read more here@jest/globals
in test - read more hereHow did you test this change?