handle relational config api not returning (#2531)

finos · Aug 21, 2023 · f07c3d2 · f07c3d2
1 parent ca6c293
commit f07c3d2
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 13 deletions.
diff --git a/.changeset/strange-otters-press.md b/.changeset/strange-otters-press.md
@@ -0,0 +1,4 @@
+---
+'@finos/legend-application-studio': patch
+'@finos/legend-graph': patch
+---
diff --git a/...c/components/editor/editor-group/connection-editor/RelationalDatabaseConnectionEditor.tsx b/...c/components/editor/editor-group/connection-editor/RelationalDatabaseConnectionEditor.tsx
@@ -1579,7 +1579,7 @@ const RelationalConnectionGeneralEditor = observer(
     const databseTypeConfigs =
       connectionValueState.editorStore.graphState
         .relationalDatabseTypeConfigurations;
-    const availableDbTypes = databseTypeConfigs
+    const availableDbTypes = databseTypeConfigs?.length
       ? // Currently H2 Flow is not returned in relational configs. We will remove this once it is properly returned as a supported flow in engine
         uniq([DatabaseType.H2, ...databseTypeConfigs.map((e) => e.type)])
       : Object.values(DatabaseType);

diff --git a/packages/legend-graph/src/graph-manager/protocol/pure/v1/V1_PureGraphManager.ts b/packages/legend-graph/src/graph-manager/protocol/pure/v1/V1_PureGraphManager.ts
@@ -3099,7 +3099,6 @@ export class V1_PureGraphManager extends AbstractPureGraphManager {
         return config;
       });
     } catch (error) {
-      assertErrorThrown(error);
       assertErrorThrown(error);
       this.logService.error(
         LogEvent.create(GRAPH_MANAGER_EVENT.RELATIONAL_CONNECTION),

diff --git a/packages/legend-graph/src/graph-manager/protocol/pure/v1/engine/V1_Engine.ts b/packages/legend-graph/src/graph-manager/protocol/pure/v1/engine/V1_Engine.ts
@@ -1065,16 +1065,12 @@ export class V1_Engine {
   async getAvailableRelationalDatabaseTypeConfigurations(): Promise<
     V1_RelationalConnectionBuilder[]
   > {
-    try {
-      return (
-        await this.engineServerClient.getAvailableRelationalDatabaseTypeConfigurations()
-      ).map((dbTypeToDataSourceAndAuthMap) =>
-        V1_RelationalConnectionBuilder.serialization.fromJson(
-          dbTypeToDataSourceAndAuthMap,
-        ),
-      );
-    } catch (error) {
-      return [];
-    }
+    return (
+      await this.engineServerClient.getAvailableRelationalDatabaseTypeConfigurations()
+    ).map((dbTypeToDataSourceAndAuthMap) =>
+      V1_RelationalConnectionBuilder.serialization.fromJson(
+        dbTypeToDataSourceAndAuthMap,
+      ),
+    );
   }
 }