fix lint issues

.changeset/tall-ducks-act.md

@@ -0,0 +1,36 @@
+---
+'@finos/legend-application-pure-ide-deployment': patch
+'@finos/legend-application-studio-deployment': patch
+'@finos/legend-extension-store-service-store': patch
+'@finos/legend-application-query-deployment': patch
+'@finos/legend-application-studio-bootstrap': patch
+'@finos/legend-application-query-bootstrap': patch
+'@finos/legend-extension-store-relational': patch
+'@finos/legend-server-showcase-deployment': patch
+'@finos/legend-extension-dsl-persistence': patch
+'@finos/legend-extension-store-flat-data': patch
+'@finos/legend-extension-dsl-data-space': patch
+'@finos/legend-extension-tracer-zipkin': patch
+'@finos/legend-extension-dsl-diagram': patch
+'@finos/legend-extension-dsl-mastery': patch
+'@finos/legend-extension-dsl-service': patch
+'@finos/legend-application-pure-ide': patch
+'@finos/legend-extension-assortment': patch
+'@finos/legend-application-studio': patch
+'@finos/legend-extension-dsl-text': patch
+'@finos/legend-application-query': patch
+'@finos/legend-server-showcase': patch
+'@finos/legend-query-builder': patch
+'@finos/legend-server-depot': patch
+'@finos/legend-application': patch
+'@finos/legend-server-sdlc': patch
+'@finos/legend-dev-utils': patch
+'@finos/stylelint-config-legend-studio': patch
+'@finos/legend-storage': patch
+'@finos/eslint-plugin-legend-studio': patch
+'@finos/legend-shared': patch
+'@finos/babel-preset-legend-studio': patch
+'@finos/legend-graph': patch
+'@finos/legend-lego': patch
+'@finos/legend-art': patch
+---

packages/eslint-plugin/src/configs/computationally-expensive.js

@@ -33,7 +33,14 @@ const TYPESCRIPT_RULES = {
     ERROR,
     { fixMixedExportsWithInlineTypeSpecifier: true },
   ],
-  '@typescript-eslint/prefer-nullish-coalescing': ERROR,
+  '@typescript-eslint/prefer-nullish-coalescing': [
+    ERROR,
+    {
+      ignoreConditionalTests: true,
+      ignoreTernaryTests: true,
+      ignoreMixedLogicalExpressions: true,
+    },
+  ],
   '@typescript-eslint/prefer-optional-chain': ERROR,
   '@typescript-eslint/no-unnecessary-condition': ERROR,
   '@typescript-eslint/no-unnecessary-type-assertion': ERROR,

packages/legend-application-query/src/components/CloneQueryServiceSetup.tsx

@@ -140,14 +140,12 @@ const CloneQueryServiceSetupContent = observer(() => {
       querySetupState.setCurrentProjectVersions([]);
       try {
         fetchSelectedProjectVersionsStatus.inProgress();
-        const v = (await flowResult(
-          depotServerClient.getVersions(
-            guaranteeNonNullable(option?.value.groupId),
-            guaranteeNonNullable(option?.value.artifactId),
-            true,
-          ),
-        )) as string[];
-        querySetupState.setCurrentProjectVersions(v);
+        const versions = await depotServerClient.getVersions(
+          guaranteeNonNullable(option?.value.groupId),
+          guaranteeNonNullable(option?.value.artifactId),
+          true,
+        );
+        querySetupState.setCurrentProjectVersions(versions);
       } catch (error) {
         assertErrorThrown(error);
         applicationStore.notificationService.notifyError(error);

packages/legend-application-query/src/components/CreateMappingQuerySetup.tsx

@@ -146,14 +146,12 @@ const CreateMappingQuerySetupContent = observer(() => {
       setupStore.setCurrentProjectVersions([]);
       try {
         fetchSelectedProjectVersionsStatus.inProgress();
-        const v = (await flowResult(
-          depotServerClient.getVersions(
-            guaranteeNonNullable(option?.value.groupId),
-            guaranteeNonNullable(option?.value.artifactId),
-            true,
-          ),
-        )) as string[];
-        setupStore.setCurrentProjectVersions(v);
+        const versions = await depotServerClient.getVersions(
+          guaranteeNonNullable(option?.value.groupId),
+          guaranteeNonNullable(option?.value.artifactId),
+          true,
+        );
+        setupStore.setCurrentProjectVersions(versions);
       } catch (error) {
         assertErrorThrown(error);
         applicationStore.notificationService.notifyError(error);

packages/legend-application-studio/src/components/editor/editor-group/element-generation-editor/ElementXTGenerationEditor.tsx

@@ -79,7 +79,7 @@ export const ExternalFormatGeneratioConfigEditor = observer(
       debouncedRegenerate()?.catch(applicationStore.alertUnhandledError);
     };
 
-    const getConfigValue = (name: string): unknown | undefined =>
+    const getConfigValue = (name: string): unknown =>
       xtState.xtGenerationState.configSpecification.configurationProperties.find(
         (e) => e.name === name,
       )?.value;

packages/legend-application-studio/src/components/editor/editor-group/element-generation-editor/FileGenerationEditor.tsx

@@ -319,7 +319,7 @@ const GenerationStringPropertyEditor = observer(
     property: GenerationProperty;
     isReadOnly: boolean;
     update: (property: GenerationProperty, newValue: PlainObject) => void;
-    getConfigValue: (name: string) => unknown | undefined;
+    getConfigValue: (name: string) => unknown;
   }) => {
     const { property, getConfigValue, isReadOnly, update } = props;
     // If there is no default value the string will be 'null'. We will treat it as an empty string
@@ -354,7 +354,7 @@ const GenerationIntegerPropertyEditor = observer(
     property: GenerationProperty;
     isReadOnly: boolean;
     update: (property: GenerationProperty, newValue: PlainObject) => void;
-    getConfigValue: (name: string) => unknown | undefined;
+    getConfigValue: (name: string) => unknown;
   }) => {
     const { property, getConfigValue, isReadOnly, update } = props;
     const defaultValue = JSON.parse(property.defaultValue) as
@@ -390,7 +390,7 @@ const GenerationBooleanPropertyEditor = observer(
     property: GenerationProperty;
     isReadOnly: boolean;
     update: (property: GenerationProperty, newValue: PlainObject) => void;
-    getConfigValue: (name: string) => unknown | undefined;
+    getConfigValue: (name: string) => unknown;
   }) => {
     const { property, getConfigValue, isReadOnly, update } = props;
     const defaultValue = JSON.parse(property.defaultValue) as
@@ -417,7 +417,7 @@ const GenerationEnumPropertyEditor = observer(
     property: GenerationProperty;
     isReadOnly: boolean;
     update: (property: GenerationProperty, newValue: PlainObject) => void;
-    getConfigValue: (name: string) => unknown | undefined;
+    getConfigValue: (name: string) => unknown;
   }) => {
     const { property, getConfigValue, isReadOnly, update } = props;
     const getEnumLabel = (_enum: string): string =>
@@ -464,7 +464,7 @@ const GenerationArrayPropertyEditor = observer(
     property: GenerationProperty;
     isReadOnly: boolean;
     update: (property: GenerationProperty, newValue: object) => void;
-    getConfigValue: (name: string) => unknown | undefined;
+    getConfigValue: (name: string) => unknown;
   }) => {
     const { property, getConfigValue, isReadOnly, update } = props;
     let defaultValue: string[] = [];
@@ -654,7 +654,7 @@ const GenerationMapPropertyEditor = observer(
     property: GenerationProperty;
     isReadOnly: boolean;
     update: (property: GenerationProperty, newValue: object) => void;
-    getConfigValue: (name: string) => unknown | undefined;
+    getConfigValue: (name: string) => unknown;
   }) => {
     const { property, getConfigValue, isReadOnly, update } = props;
     // Right now, always assume this is a map between STRING and STRING (might need to support STRING - INTEGER and STRING - BOOLEAN)
@@ -884,7 +884,7 @@ const GenerationMapPropertyEditor = observer(
 export const GenerationPropertyEditor = observer(
   (props: {
     property: GenerationProperty;
-    getConfigValue: (name: string) => unknown | undefined;
+    getConfigValue: (name: string) => unknown;
     isReadOnly: boolean;
     update: (property: GenerationProperty, newValue: object) => void;
   }) => {
@@ -1039,7 +1039,7 @@ export const FileGenerationConfigurationEditor = observer(
       [handleDrop],
     );
 
-    const getConfigValue = (name: string): unknown | undefined =>
+    const getConfigValue = (name: string): unknown =>
       getNullableFileGenerationConfig(fileGeneration, name)?.value;
 
     return (

packages/legend-application-studio/src/components/editor/editor-group/external-format-editor/DSL_ExternalFormat_SchemaSetModelGenerationEditor.tsx

@@ -77,7 +77,7 @@ export const SchemaSetModelGenerationEditor = observer(
     const resetProperties = (): void => {
       modelGenerationState.setConfigurationProperty([]);
     };
-    const getConfigValue = (name: string): unknown | undefined =>
+    const getConfigValue = (name: string): unknown =>
       modelGenerationState.getConfigValue(name);
     const targetBindingPathValidationMessage =
       Boolean(modelGenerationState.targetBinding) &&

packages/legend-application-studio/src/components/editor/editor-group/mapping-editor/InstanceSetImplementationEditor.tsx

@@ -118,7 +118,7 @@ export const InstanceSetImplementationSourceExplorer = observer(
     const [
       sourceElementForSourceSelectorModal,
       setSourceElementForSourceSelectorModal,
-    ] = useState<MappingElementSource | undefined | null>();
+    ] = useState<MappingElementSource>();
     const CHANGING_SOURCE_ON_EMBEDDED =
       'Changing source on mapping with embedded children will delete all its children';
     const showSourceSelectorModal = (): void => {

packages/legend-application-studio/src/components/editor/editor-group/mapping-editor/InstanceSetImplementationSourceSelectorModal.tsx

@@ -70,9 +70,7 @@ export interface MappingElementSourceSelectOption {
   value: unknown;
 }
 
-export const getSourceElementLabel = (
-  srcElement: unknown | undefined,
-): string => {
+export const getSourceElementLabel = (srcElement: unknown): string => {
   let sourceLabel = '(none)';
   if (srcElement instanceof Class) {
     sourceLabel = srcElement.name;
@@ -90,7 +88,7 @@ export const getSourceElementLabel = (
 
 // TODO: add more visual cue to the type of source (class vs. flat-data vs. db)
 export const buildMappingElementSourceOption = (
-  source: MappingElementSource | undefined,
+  source: MappingElementSource,
 ): MappingElementSourceSelectOption | null => {
   if (source instanceof Class) {
     return buildElementOption(source) as MappingElementSourceSelectOption;
@@ -120,7 +118,7 @@ export const InstanceSetImplementationSourceSelectorModal = observer(
      * Pass in `null` when we want to open the modal using the existing source.
      * Pass any other to open the source modal using that value as the initial state of the modal.
      */
-    sourceElementToSelect: MappingElementSource | null;
+    sourceElementToSelect: MappingElementSource;
     closeModal: () => void;
   }) => {
     const {

packages/legend-application-studio/src/components/editor/editor-group/project-configuration-editor/ProjectConfigurationEditor.tsx

@@ -662,13 +662,11 @@ export const ProjectConfigurationEditor = observer(() => {
             const dependencyToAdd = new ProjectDependency(
               projectToAdd.coordinates,
             );
-            const versions = (await flowResult(
-              editorStore.depotServerClient.getVersions(
-                projectToAdd.groupId,
-                projectToAdd.artifactId,
-                true,
-              ),
-            )) as string[];
+            const versions = await editorStore.depotServerClient.getVersions(
+              projectToAdd.groupId,
+              projectToAdd.artifactId,
+              true,
+            );
             configState.versions.set(dependencyToAdd.projectId, versions);
             dependencyToAdd.setVersionId(versions[0] ?? '');
             currentProjectConfiguration.addProjectDependency(dependencyToAdd);

packages/legend-application-studio/src/components/editor/editor-group/project-configuration-editor/ProjectDependencyEditor.tsx

@@ -785,17 +785,15 @@ const ProjectVersionDependencyEditor = observer(
         if (val) {
           try {
             fetchSelectedProjectVersionsStatus.inProgress();
-            const v = (await flowResult(
-              editorStore.depotServerClient.getVersions(
-                guaranteeNonNullable(projectDependency.groupId),
-                guaranteeNonNullable(projectDependency.artifactId),
-                true,
-              ),
-            )) as string[];
-            configState.versions.set(val.value.coordinates, v);
-            if (v.length) {
+            const _versions = await editorStore.depotServerClient.getVersions(
+              guaranteeNonNullable(projectDependency.groupId),
+              guaranteeNonNullable(projectDependency.artifactId),
+              true,
+            );
+            configState.versions.set(val.value.coordinates, _versions);
+            if (_versions.length) {
               projectDependency.setVersionId(
-                guaranteeNonNullable(v[v.length - 1]),
+                guaranteeNonNullable(_versions[_versions.length - 1]),
               );
               flowResult(dependencyEditorState.fetchDependencyReport()).catch(
                 applicationStore.alertUnhandledError,

packages/legend-application-studio/src/stores/editor/__tests__/ProjectDependencyManager.test.ts

@@ -40,6 +40,7 @@ import {
   TEST_DATA__dependencyMainGraphEntities2,
   TEST_DATA__projectsData,
 } from './TEST_DATA__ProjectDependencyManager.js';
+import { flowResult } from 'mobx';
 
 const testDependingOnDifferentProjectVersions = [
   {
@@ -443,9 +444,11 @@ test(
     getClassProperty(firm, 'mainPerson');
     getClassProperty(person, 'mainFirm');
     // load association 1/2
-    await editorStore.graphState.loadEntityChangesToGraph(
-      [],
-      TEST_DATA__dependencyMainGraphEntities2 as Entity[],
+    await flowResult(
+      editorStore.graphState.loadEntityChangesToGraph(
+        [],
+        TEST_DATA__dependencyMainGraphEntities2 as Entity[],
+      ),
     );
     expect(firm.propertiesFromAssociations.length).toBe(2);
     expect(person.propertiesFromAssociations.length).toBe(2);
@@ -466,7 +469,7 @@ test(
     getClassProperty(firm, 'mainPerson2');
     getClassProperty(person, 'mainFirm2');
     // clear current graph
-    await editorStore.graphState.loadEntityChangesToGraph([], []);
+    await flowResult(editorStore.graphState.loadEntityChangesToGraph([], []));
     expect(editorStore.graphManagerState.graph.allOwnElements.length).toBe(0);
     expect(firm.propertiesFromAssociations.length).toBe(0);
     expect(person.propertiesFromAssociations.length).toBe(0);

packages/legend-application-studio/src/stores/editor/editor-state/element-editor-state/external-format/DSL_ExternalFormat_SchemaSetEditorState.ts

@@ -129,7 +129,7 @@ export class SchemaSetModelGenerationState {
     this.targetBinding = val;
   }
 
-  getConfigValue(name: string): unknown | undefined {
+  getConfigValue(name: string): unknown {
     return this.getConfig(name)?.value;
   }
 

packages/legend-application-studio/src/stores/editor/editor-state/element-editor-state/mapping/DEPRECATED__MappingTestState.ts

@@ -576,7 +576,7 @@ export class DEPRECATED__MappingTestState extends MappingEditorTabState {
   }
 
   setInputDataStateBasedOnSource(
-    source: MappingElementSource | undefined,
+    source: MappingElementSource,
     populateWithMockData: boolean,
   ): void {
     if (source === undefined || source instanceof Class) {

packages/legend-application-studio/src/stores/editor/editor-state/element-editor-state/mapping/MappingEditorState.ts

@@ -274,7 +274,7 @@ export const getMappingElementLabel = (
 export const getMappingElementSource = (
   mappingElement: MappingElement,
   plugins: LegendStudioApplicationPlugin[],
-): MappingElementSource | undefined => {
+): MappingElementSource => {
   if (mappingElement instanceof INTERNAL__UnknownSetImplementation) {
     return undefined;
   } else if (mappingElement instanceof OperationSetImplementation) {
@@ -941,7 +941,7 @@ export class MappingEditorState extends ElementEditorState {
 
   *changeClassMappingSourceDriver(
     setImplementation: InstanceSetImplementation,
-    newSource: MappingElementSource | undefined,
+    newSource: MappingElementSource,
   ): GeneratorFn<void> {
     const currentSource = getMappingElementSource(
       setImplementation,

packages/legend-application-studio/src/stores/editor/editor-state/element-editor-state/mapping/MappingExecutionState.ts

@@ -594,7 +594,7 @@ export class MappingExecutionState extends MappingEditorTabState {
   }
 
   setInputDataStateBasedOnSource(
-    source: unknown | undefined,
+    source: unknown,
     populateWithMockData: boolean,
   ): void {
     if (source instanceof Class) {

packages/legend-application-studio/src/stores/editor/sidebar-state/testable/GlobalTestRunnerState.ts

@@ -328,7 +328,7 @@ export const getTestableResultFromAssertionStatus = (
 export const getTestableResultFromTestResults = (
   testResults: (TestResult | undefined)[] | undefined,
 ): TESTABLE_RESULT => {
-  if (testResults === undefined || !testResults.length) {
+  if (!testResults?.length) {
     return TESTABLE_RESULT.DID_NOT_RUN;
   }
   if (

packages/legend-application-studio/src/stores/extensions/DSL_Mapping_LegendStudioApplicationPlugin_Extension.ts

@@ -64,7 +64,7 @@ export type SetImplementationMappingElementLabelInfoBuilder = (
 
 export type MappingElementSourceExtractor = (
   mappingElement: MappingElement,
-) => MappingElementSource | undefined;
+) => MappingElementSource;
 
 export type MappingElementStateCreator = (
   mappingElement: MappingElement | undefined,
@@ -106,7 +106,7 @@ export type NewConnectionSnippetSuggestion = PureGrammarTextSuggestion;
  */
 export type InstanceSetImplementationSourceUpdater = (
   setImplementation: InstanceSetImplementation,
-  newSource: unknown | undefined,
+  newSource: unknown,
 ) => boolean;
 
 export type MappingSourceTypeInfoGetter = (

packages/legend-application/src/stores/terminal/XTerm.ts

@@ -46,6 +46,7 @@ import {
   IllegalStateError,
   isMatchingKeyCombination,
   LogEvent,
+  noop,
   prettyCONSTName,
   uniqBy,
 } from '@finos/legend-shared';
@@ -338,6 +339,7 @@ export class XTerm extends Terminal {
                 command,
                 text,
               )
+              .catch(noop())
               .finally(() => {
                 this.isRunningCommand = false;
                 if (!this.isFlushed) {

packages/legend-extension-dsl-persistence/src/graph/DSL_Persistence_HashUtils.ts

@@ -79,7 +79,7 @@ export enum PERSISTENCE_HASH_STRUCTURE {
 
   // auditing v2
   AUDITING_DATE_TIME = 'AUDITING_DATE_TIME',
-  NO_AUDITING_V2 = 'NO_AUDITING',
+  NO_AUDITING_V2 = 'NO_AUDITING_V2',
 
   // trigger
   MANUAL_TRIGGER = 'MANUAL_TRIGGER',