Modify MappingModelCoverageAnalysis to return PMCD for the model coverage #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Test Results 687 files + 687 687 suites +687 1h 1m 10s ⏱️ + 1h 1m 10s Results for commit 17c507c. ± Comparison against base commit fb42a4c. ♻️ This comment has been updated with latest results. |
Closed
3 tasks
akphi
requested changes
Sep 7, 2023
...h/legend-engine-xt-analytics-search-pure/src/main/resources/core_analytics_search/trans.pure
Show resolved
Hide resolved
...alytics-mapping-pure/src/main/resources/core_analytics_mapping/modelCoverage/serializer.pure
Outdated
Show resolved
Hide resolved
...-analytics-mapping-pure/src/main/resources/core_analytics_mapping/modelCoverage/utility.pure
Show resolved
Hide resolved
finos-admin
requested review from
pierredebelen,
epsstan,
davidharte-gs,
gs-ssh16 and
hardikmaheshwari
as code owners
gayathrir11
force-pushed
the
generation
branch
2 times, most recently
from
024cf48
to
5a36920
Compare
gayathrir11
force-pushed
the
generation
branch
5 times, most recently
from
461351e
to
47ef1aa
Compare
akphi
previously approved these changes
Sep 29, 2023
gayathrir11
force-pushed
the
generation
branch
2 times, most recently
from
74a7a3e
to
da0a0ec
Compare
akphi
previously approved these changes
Oct 3, 2023
gayathrir11
force-pushed
the
generation
branch
from
da0a0ec
to
1aeef1a
Compare
akphi
previously approved these changes
Oct 4, 2023
gs-ssh16
previously approved these changes
Oct 4, 2023
gayathrir11
force-pushed
the
generation
branch
from
1aeef1a
to
e901cab
Compare
gs-ssh16
previously approved these changes
Oct 13, 2023
gs-ssh16
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
Which issue(s) this PR fixes:
Related to finos/legend-studio#2346
Other notes for reviewers:
Does this PR introduce a user-facing change?