Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force override of rollup to resolve (see url in comments) #406

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Force override of rollup to resolve (see url in comments) #406

merged 1 commit into from
Sep 25, 2024

Conversation

rocketstack-matt
Copy link
Member

@rocketstack-matt rocketstack-matt commented Sep 24, 2024 •
edited
Loading

@rocketstack-matt rocketstack-matt changed the title Force override of rollup to resolve https://github.com/advisories/GHS… Force override of rollup to resolve (see url in comments) Sep 24, 2024
willosborne
willosborne approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@willosborne willosborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some manual testing locally and validation seems to be fine. Was able to see both JSON schema and spectral working fine in both green and red cases.

@rocketstack-matt rocketstack-matt merged commit 2aec3b1 into finos:main Sep 25, 2024
3 checks passed
@rocketstack-matt rocketstack-matt deleted the rollup-override branch September 25, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willosborne willosborne willosborne approved these changes

@aidanm3341 aidanm3341 Awaiting requested review from aidanm3341 aidanm3341 is a code owner

@lbulanti-ms lbulanti-ms Awaiting requested review from lbulanti-ms lbulanti-ms is a code owner

@grahampacker-ms grahampacker-ms Awaiting requested review from grahampacker-ms grahampacker-ms is a code owner

@jpgough-ms jpgough-ms Awaiting requested review from jpgough-ms jpgough-ms is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rocketstack-matt @willosborne