SDA-4322: About Symphony - Unable to dismiss the pod URL editor by pressing ESC key #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbenmoussati
reviewed
Oct 2, 2023
| @@ -276,6 +277,15 @@ export default class AboutApp extends React.Component<{}, IState> { | |||
| const { value } = e.target; | |||
| this.setState({ updatedHostname: value }); | |||
| this.handlePodInputBlur(e); | |||
| this.previousUrl = value; | |||
| } | |||
| if (e.keyCode === 27) { | |||
There was a problem hiding this comment.
27 looks like a magic number here, what about defining this keyCode in a const or maybe something like
Suggested change
| if (e.keyCode === 27) { | |
| if (e.key.toLowerCase() === 'escape') { |
There was a problem hiding this comment.
Im not sure this is a magic number but it is predefined for both mac and windows. I so I bet it will just work. Let me enwrap it in a constant
NguyenTranHoangSym
force-pushed
the
SDA-4322
branch
from
4450a31 to
6616349
Compare
sbenmoussati
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ability to:
Related PRs