Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with newline #4

Closed
wants to merge 9 commits into from
Closed

Errors with newline #4

wants to merge 9 commits into from

Conversation

tiagosomda
Copy link

It looks like there was a problem with multiple commands being split into different lines.

I believe it had something to do with a newline character after '&&' in between commands.
You can either have it all in one line or keep it in separate lines by concatenating the strings.

It is now working perfectly for me!
Thanks for the script!

@tiagosomda tiagosomda mentioned this pull request Jul 3, 2017
@finom
Copy link
Owner

finom commented Jul 4, 2017

@tiagosomda thank you for the PR. Can you please do the following:

  • Squash all commits into one
  • Fix CI errors
  • Use semantic-release commit format so a new version will be published automatically (e. g. "fix: Don't split commands with newline")

@finom finom closed this Jul 4, 2017
@finom
Copy link
Owner

finom commented Jul 4, 2017

Just pushed fix by myself. Thank you for the PR. It just had some issues which blocked me to accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants