Support email for test notifications

finlabsuk · Jan 10, 2023 · b6f3e76 · b6f3e76
1 parent 838af5b
commit b6f3e76
Show file tree

Hide file tree

Showing 16 changed files with 279 additions and 149 deletions.
diff --git a/...penBanking.Library.Connector/Fluent/AccountAndTransaction/AccountAccessConsentsContext.cs b/...penBanking.Library.Connector/Fluent/AccountAndTransaction/AccountAccessConsentsContext.cs
@@ -25,7 +25,7 @@
 namespace FinnovationLabs.OpenBanking.Library.Connector.Fluent.AccountAndTransaction
 {
     public interface IAccountAccessConsentsContext :
-        IConsentContext<AccountAccessConsentRequest, AccountAccessConsentCreateResponse, AccountAccessConsentReadResponse>,
+        IConsentContext<AccountAccessConsentRequest, AccountAccessConsentCreateResponse, AccountAccessConsentCreateResponse>,
         IDeleteConsentContext
     {
         /// <summary>
@@ -41,7 +41,7 @@ public interface IAccountAccessConsentsContext :
 
     internal interface IAccountAccessConsentsContextInternal :
         IAccountAccessConsentsContext,
-        IConsentContextInternal<AccountAccessConsentRequest, AccountAccessConsentCreateResponse, AccountAccessConsentReadResponse>,
+        IConsentContextInternal<AccountAccessConsentRequest, AccountAccessConsentCreateResponse, AccountAccessConsentCreateResponse>,
         IDeleteConsentContextInternal { }
 
     internal class AccountAccessConsentsConsentContext :
@@ -93,7 +93,7 @@ public AccountAccessConsentsConsentContext(ISharedContext sharedContext)
                     _sharedContext.SoftwareStatementProfileCachedRepo,
                     _sharedContext.Instrumentation));
 
-        public IObjectRead<AccountAccessConsentReadResponse, ConsentReadParams> ReadObject { get; }
+        public IObjectRead<AccountAccessConsentCreateResponse, ConsentReadParams> ReadObject { get; }
 
         public IObjectCreate<AccountAccessConsentRequest, AccountAccessConsentCreateResponse, ConsentCreateParams>
             CreateObject { get; }

diff --git a/...ry.Connector/Models/Public/AccountAndTransaction/Response/AccountAccessConsentResponse.cs b/...ry.Connector/Models/Public/AccountAndTransaction/Response/AccountAccessConsentResponse.cs
@@ -27,6 +27,8 @@ internal AccountAccessConsentBaseResponse(
             Guid bankRegistrationId,
             string externalApiId,
             string? externalApiUserId,
+            DateTimeOffset authContextModified,
+            string? authContextModifiedBy,
             Guid accountAndTransactionApiId) : base(
             id,
             created,
@@ -35,7 +37,9 @@ internal AccountAccessConsentBaseResponse(
             warnings,
             bankRegistrationId,
             externalApiId,
-            externalApiUserId)
+            externalApiUserId,
+            authContextModified,
+            authContextModifiedBy)
         {
             AccountAndTransactionApiId = accountAndTransactionApiId;
         }
@@ -60,6 +64,8 @@ internal AccountAccessConsentCreateResponse(
             Guid bankRegistrationId,
             string externalApiId,
             string? externalApiUserId,
+            DateTimeOffset authContextModified,
+            string? authContextModifiedBy,
             Guid accountAndTransactionApiId,
             OBReadConsentResponse1? externalApiResponse) : base(
             id,
@@ -70,6 +76,8 @@ internal AccountAccessConsentCreateResponse(
             bankRegistrationId,
             externalApiId,
             externalApiUserId,
+            authContextModified,
+            authContextModifiedBy,
             accountAndTransactionApiId)
         {
             ExternalApiResponse = externalApiResponse;
@@ -84,43 +92,4 @@ internal AccountAccessConsentCreateResponse(
         /// </summary>
         public OBReadConsentResponse1? ExternalApiResponse { get; }
     }
-
-    /// <summary>
-    ///     Response to AccountAccessConsent Read requests.
-    /// </summary>
-    public class AccountAccessConsentReadResponse : AccountAccessConsentBaseResponse
-    {
-        internal AccountAccessConsentReadResponse(
-            Guid id,
-            DateTimeOffset created,
-            string? createdBy,
-            string? reference,
-            IList<string>? warnings,
-            Guid bankRegistrationId,
-            string externalApiId,
-            string? externalApiUserId,
-            Guid accountAndTransactionApiId,
-            OBReadConsentResponse1 externalApiResponse) : base(
-            id,
-            created,
-            createdBy,
-            reference,
-            warnings,
-            bankRegistrationId,
-            externalApiId,
-            externalApiUserId,
-            accountAndTransactionApiId)
-        {
-            ExternalApiResponse = externalApiResponse;
-        }
-
-        /// <summary>
-        ///     Response object OBReadConsentResponse1 from UK Open Banking Read-Write Account and Transaction API spec
-        ///     <a
-        ///         href="https://github.com/OpenBankingUK/read-write-api-specs/blob/v3.1.8r5/dist/openapi/account-info-openapi.yaml" />
-        ///     v3.1.9r5 <a />. Open Banking Connector will automatically
-        ///     translate <i>to</i> this from an older format for banks supporting an earlier spec version.
-        /// </summary>
-        public OBReadConsentResponse1 ExternalApiResponse { get; }
-    }
 }
diff --git a/...rary.Connector/Models/Public/PaymentInitiation/Response/DomesticPaymentConsentResponse.cs b/...rary.Connector/Models/Public/PaymentInitiation/Response/DomesticPaymentConsentResponse.cs
@@ -40,6 +40,8 @@ internal DomesticPaymentConsentBaseResponse(
             Guid bankRegistrationId,
             string externalApiId,
             string? externalApiUserId,
+            DateTimeOffset authContextModified,
+            string? authContextModifiedBy,
             Guid paymentInitiationApiId) : base(
             id,
             created,
@@ -48,7 +50,9 @@ internal DomesticPaymentConsentBaseResponse(
             warnings,
             bankRegistrationId,
             externalApiId,
-            externalApiUserId)
+            externalApiUserId,
+            authContextModified,
+            authContextModifiedBy)
         {
             PaymentInitiationApiId = paymentInitiationApiId;
         }
@@ -73,6 +77,8 @@ internal DomesticPaymentConsentCreateResponse(
             Guid bankRegistrationId,
             string externalApiId,
             string? externalApiUserId,
+            DateTimeOffset authContextModified,
+            string? authContextModifiedBy,
             Guid paymentInitiationApiId,
             PaymentInitiationModelsPublic.OBWriteDomesticConsentResponse5? externalApiResponse) : base(
             id,
@@ -83,6 +89,8 @@ internal DomesticPaymentConsentCreateResponse(
             bankRegistrationId,
             externalApiId,
             externalApiUserId,
+            authContextModified,
+            authContextModifiedBy,
             paymentInitiationApiId)
         {
             ExternalApiResponse = externalApiResponse;
@@ -106,6 +114,8 @@ internal DomesticPaymentConsentReadResponse(
             Guid bankRegistrationId,
             string externalApiId,
             string? externalApiUserId,
+            DateTimeOffset authContextModified,
+            string? authContextModifiedBy,
             Guid paymentInitiationApiId,
             PaymentInitiationModelsPublic.OBWriteDomesticConsentResponse5 externalApiResponse) : base(
             id,
@@ -116,6 +126,8 @@ internal DomesticPaymentConsentReadResponse(
             bankRegistrationId,
             externalApiId,
             externalApiUserId,
+            authContextModified,
+            authContextModifiedBy,
             paymentInitiationApiId)
         {
             ExternalApiResponse = externalApiResponse;
@@ -139,6 +151,8 @@ internal DomesticPaymentConsentReadFundsConfirmationResponse(
             Guid bankRegistrationId,
             string externalApiId,
             string? externalApiUserId,
+            DateTimeOffset authContextModified,
+            string? authContextModifiedBy,
             Guid paymentInitiationApiId,
             PaymentInitiationModelsPublic.OBWriteFundsConfirmationResponse1 externalApiResponse) : base(
             id,
@@ -149,6 +163,8 @@ internal DomesticPaymentConsentReadFundsConfirmationResponse(
             bankRegistrationId,
             externalApiId,
             externalApiUserId,
+            authContextModified,
+            authContextModifiedBy,
             paymentInitiationApiId)
         {
             ExternalApiResponse = externalApiResponse;

diff --git a/src/OpenBanking.Library.Connector/Models/Public/Response/ConsentResponseBase.cs b/src/OpenBanking.Library.Connector/Models/Public/Response/ConsentResponseBase.cs
@@ -14,12 +14,16 @@ internal ConsentResponseBase(
         IList<string>? warnings,
         Guid bankRegistrationId,
         string externalApiId,
-        string? externalApiUserId) : base(id, created, createdBy, reference)
+        string? externalApiUserId,
+        DateTimeOffset authContextModified,
+        string? authContextModifiedBy) : base(id, created, createdBy, reference)
     {
         Warnings = warnings;
         BankRegistrationId = bankRegistrationId;
         ExternalApiId = externalApiId;
         ExternalApiUserId = externalApiUserId;
+        AuthContextModified = authContextModified;
+        AuthContextModifiedBy = authContextModifiedBy;
     }
 
     /// <summary>
@@ -37,10 +41,14 @@ internal ConsentResponseBase(
     ///     same bank but we do not assume global uniqueness between objects created at multiple banks.
     /// </summary>
     public string ExternalApiId { get; }
-    
+
     /// <summary>
     ///     User ID at external API (bank) which may or may not be available via ID token "sub" claim. If retrieved from ID
     ///     token or supplied on object creation, it will be stored here.
     /// </summary>
     public string? ExternalApiUserId { get; }
+
+    public DateTimeOffset AuthContextModified { get; }
+
+    public string? AuthContextModifiedBy { get; }
 }
diff --git a/....Connector/Models/Public/VariableRecurringPayments/Response/DomesticVrpConsentResponse.cs b/....Connector/Models/Public/VariableRecurringPayments/Response/DomesticVrpConsentResponse.cs
@@ -38,6 +38,8 @@ internal DomesticVrpConsentBaseResponse(
             Guid bankRegistrationId,
             string externalApiId,
             string? externalApiUserId,
+            DateTimeOffset authContextModified,
+            string? authContextModifiedBy,
             Guid variableRecurringPaymentsApiId) : base(
             id,
             created,
@@ -46,7 +48,9 @@ internal DomesticVrpConsentBaseResponse(
             warnings,
             bankRegistrationId,
             externalApiId,
-            externalApiUserId)
+            externalApiUserId,
+            authContextModified,
+            authContextModifiedBy)
         {
             VariableRecurringPaymentsApiId = variableRecurringPaymentsApiId;
         }
@@ -72,6 +76,8 @@ internal DomesticVrpConsentCreateResponse(
             Guid bankRegistrationId,
             string externalApiId,
             string? externalApiUserId,
+            DateTimeOffset authContextModified,
+            string? authContextModifiedBy,
             Guid variableRecurringPaymentsApiId,
             VariableRecurringPaymentsModelsPublic.OBDomesticVRPConsentResponse? externalApiResponse) : base(
             id,
@@ -82,6 +88,8 @@ internal DomesticVrpConsentCreateResponse(
             bankRegistrationId,
             externalApiId,
             externalApiUserId,
+            authContextModified,
+            authContextModifiedBy,
             variableRecurringPaymentsApiId)
         {
             ExternalApiResponse = externalApiResponse;
@@ -104,6 +112,8 @@ internal DomesticVrpConsentReadResponse(
             Guid bankRegistrationId,
             string externalApiId,
             string? externalApiUserId,
+            DateTimeOffset authContextModified,
+            string? authContextModifiedBy,
             Guid variableRecurringPaymentsApiId,
             VariableRecurringPaymentsModelsPublic.OBDomesticVRPConsentResponse externalApiResponse) : base(
             id,
@@ -114,6 +124,8 @@ internal DomesticVrpConsentReadResponse(
             bankRegistrationId,
             externalApiId,
             externalApiUserId,
+            authContextModified,
+            authContextModifiedBy,
             variableRecurringPaymentsApiId)
         {
             ExternalApiResponse = externalApiResponse;
@@ -137,6 +149,8 @@ internal DomesticVrpConsentReadFundsConfirmationResponse(
             Guid bankRegistrationId,
             string externalApiId,
             string? externalApiUserId,
+            DateTimeOffset authContextModified,
+            string? authContextModifiedBy,
             Guid variableRecurringPaymentsApiId,
             VariableRecurringPaymentsModelsPublic.OBVRPFundsConfirmationResponse externalApiResponse) : base(
             id,
@@ -147,6 +161,8 @@ internal DomesticVrpConsentReadFundsConfirmationResponse(
             bankRegistrationId,
             externalApiId,
             externalApiUserId,
+            authContextModified,
+            authContextModifiedBy,
             variableRecurringPaymentsApiId)
         {
             ExternalApiResponse = externalApiResponse;