Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflows): upgrade actions v2->v3 #21

Merged
merged 3 commits into from
May 2, 2023
Merged

ci(workflows): upgrade actions v2->v3 #21

merged 3 commits into from
May 2, 2023

Conversation

necipallef
Copy link
Contributor

ss

  • Prevents the deprecation warning (see ss)

@github-actions
Copy link

github-actions bot commented May 1, 2023

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 50% 3/6
🟢 Branches 100% 0/0
🔴 Functions 50% 1/2
🔴 Lines 25% 1/4

Test suite run success

1 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 5eb6d10

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟡 All files 50 100 50 25
🟢  greeting.ts 100 100 100 100
🔴  index.ts 0 100 0 0 1-4

@necipallef
Copy link
Contributor Author

necipallef commented May 2, 2023

There is another warning that pops up, which goes like this:

The set-output command is deprecated and will be disabled soon.
Please upgrade to using Environment Files.
For more information see:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

This warning generates from jaywcjlove/coverage-badges-cli and JamesIves/github-pages-deploy-action. The problem needs to go away when these libraries use @actions/core: 1.10.0.

I wanted to use a more up-to-date version of the JamesIves/github-pages-deploy-action, so I upgraded it. Below are the improvements:

  • no breaking changes as far as I can see
  • it switches from @actions/core: 1.6.0 to @actions/core: 1.10.0
  • from node12 to node16
  • does other fixes, such as adding node_modules to .gitignore, fixing a lot of typos in documentation, etc, so I'd assume it is in a lot better shape than the current version that we use. You can check out the diff check here.

I couldn't find any benefits from upgrading jaywcjlove/coverage-badges-cli so I left it as is.

It turns out that the issue doesn't disappear with @actions/core: 1.10.0, you can check out this thread. But still, I think it is worth to upgrade JamesIves/github-pages-deploy-action.

@necipallef
Copy link
Contributor Author

I pushed another commit because the gh-pages deployment is broken. Here is a broken build from the Segment repo, and here is a fixed version.

Here is the diff check if you are interested.

@necipallef necipallef merged commit 4a3b0e0 into main May 2, 2023
@necipallef necipallef deleted the chore/workflows branch May 2, 2023 12:09
@fingerprint-dx-team
Copy link

🎉 This PR is included in version 1.0.0-test.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants