Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Labmda support INTER-161 #32

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Add AWS Labmda support INTER-161 #32

merged 4 commits into from
Aug 9, 2023

Conversation

ilfa
Copy link
Member

@ilfa ilfa commented Aug 2, 2023

In AWS Lambda environment there is no multiprocessing.pool for Python > 3.7.
So in this PR I added DummyPool to make async mode work like sync, but at least it works.

For a real async mode, the customer can provide their own ThreadPool instance.

Bonus:

  • Added python-dotenv to the requirements template
  • Added max version for urllib3

@ilfa ilfa requested a review from JuroUhlar August 2, 2023 16:16
@ilfa ilfa temporarily deployed to test August 2, 2023 16:27 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5429 3081 57% 0% 🟢

New Files

File Coverage Status
fingerprint_pro_server_api_sdk/dummy_pool.py 0% 🟢
TOTAL 0% 🟢

Modified Files

File Coverage Status
fingerprint_pro_server_api_sdk/api/fingerprint_api.py 89% 🟢
fingerprint_pro_server_api_sdk/api_client.py 59% 🟢
fingerprint_pro_server_api_sdk/configuration.py 79% 🟢
TOTAL 75% 🟢

updated for commit: 06dbbb7 by action🐍

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

This PR will create a minor release 🚀

2.5.0 (2023-08-02)

Features

  • make SDK more independent from environment (1d017c1), closes #31

@ilfa ilfa mentioned this pull request Aug 2, 2023
Copy link
Contributor

@JuroUhlar JuroUhlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix make sense to me and the SDK works when testing locally, good enough for me 👍

@ilfa ilfa merged commit e9220c4 into main Aug 9, 2023
@ilfa ilfa deleted the feat/aws-labmda-support branch August 9, 2023 09:54
@ilfa
Copy link
Member Author

ilfa commented Aug 9, 2023

🎉 This PR is included in version 2.5.0-dev.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ilfa
Copy link
Member Author

ilfa commented Aug 10, 2023

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ilfa ilfa added the released label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants