forked from apache/druid
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Segment Schema Publishing and Polling for Efficient Datasource Schema Building #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d1c0dca.
…actor on broker side
findingrish
changed the title
Coordinator schema read write
Introduce Segment Schema Publishing and Polling for Efficient Datasource Schema Building
Feb 1, 2024
andrisnoko
pushed a commit
to andrisnoko/druid
that referenced
this pull request
Jul 17, 2024
add empty response and GrpcResponseHandler tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: apache#14989
The initial step in optimizing segment metadata was to centralize the construction of datasource schema in the Coordinator (apache#14985). Thereafter, we addressed the problem of publishing schema for realtime segments (apache#15475). Subsequently, our goal is to eliminate the requirement for regularly executing queries to obtain segment schema information.
This is the final change which involves publishing segment schema for finalized segments from task and periodically polling them in the Coordinator.
Design
Database
Schema Table
Table Name:
SegmentSchema
Purpose: Store unique schema for segment.
Columns
Segments Table
New columns will be added to the already existing
Segments
table.Columns
Task
Changes in the task to publish schema along with segment metadata.
Streaming
StreamAppenderator
to get the RowSignature, AggregatorFactories and numRows for the segment.Batch
TBA
MSQ
TBA
Coordinator
Schema Poll
Schema Caching
SegmentMetadataCache changes
Schema Cleanup
Testing
TBA
Potential side effects
TBA
Limitations
TBA
Upgrade considerations
TBA