Merge pull request #482 from willow-ahrens/wma/fix481

Wma/fix481
finch-tensor · Mar 25, 2024 · 14e0f0f · 14e0f0f · mtsokol · Mar 25, 2024
2 parents ba60c84 + f4e8dfb
commit 14e0f0f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Finch"
 uuid = "9177782c-1635-4eb9-9bfb-d9dfa25e6bce"
 authors = ["Willow Ahrens"]
-version = "0.6.19"
+version = "0.6.20"
 
 [deps]
 AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"

diff --git a/src/interface/lazy.jl b/src/interface/lazy.jl
@@ -213,7 +213,8 @@ Base.copyto!(out, bc::Broadcasted{LazyStyle{N}}) where {N} = copyto!(out, copy(b
 
 function Base.copy(bc::Broadcasted{LazyStyle{N}}) where {N}
     bc_lgc = broadcast_to_logic(bc)
-    data = broadcast_to_query(bc_lgc, [field(gensym(:i)) for _ in 1:N])
+    idxs = [field(gensym(:i)) for _ in 1:N]
+    data = reorder(broadcast_to_query(bc_lgc, idxs), idxs)
     extrude = ntuple(n -> broadcast_to_extrude(bc_lgc, n), N)
     return LazyTensor{eltype(bc)}(identify(data), extrude)
 end

diff --git a/test/test_interface.jl b/test/test_interface.jl
@@ -196,4 +196,11 @@ using Finch: AsArray
         @test Array(A_result) == A_t
         @test permutedims(A_tns, perm) == A_t
     end
+
+    #https://github.com/willow-ahrens/Finch.jl/issues/481
+    let
+        r = fsprand(1, 10, 10, 0.01)
+        r_tns = Tensor(Dense(Dense(Dense(Element(0.0)))), r)
+        @test r_tns + r_tns == 2 * r_tns
+    end
 end