Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove outdated rollup-plugin-flow causing es bundle error #74

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

rosskevin
Copy link
Contributor

Closes #72

I found an outdated rollup-plugin-flow causing a bad bundle to be created. Removal of flow is already covered by the babel preset.

@erikras if you could publish this it will solve a problem for a large number of es users since the 2.0.2 bundle is invalid without this fix.

@rosskevin rosskevin changed the title remove outdated rollup-plugin-flow causing #72 remove outdated rollup-plugin-flow causing es bundle error Mar 22, 2019
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #74   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          75     75           
  Branches       17     17           
=====================================
  Hits           75     75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250ae14...aa24d7d. Read the comment docs.

@Noitidart
Copy link

Thanks very much for trying to fix this up! I installed from this PR with npm i final-form/react-final-form-arrays#pull/74/head but now I get:

Module not found: Error: Can't resolve 'react-final-form-arrays' in 'C:\Users\Mercurius\Documents\GitHub\Homie-Web\assets\js\components\TaskForm'

:(

@rosskevin
Copy link
Contributor Author

@Noitidart your error is unrelated. This fix is to rollup and this repo does not contain the dist.

@Noitidart
Copy link

Thanks @rosskevin for the reply. When I did npm i [email protected] it works though. :(

Oh! Maybe the problem is in installing how I installed from pull request with npm i final-form/react-final-form-arrays#pull/74/head?

@rosskevin
Copy link
Contributor Author

@erikras please LGTM, the dist is broken.

@erikras erikras merged commit 4cd58c0 into final-form:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FieldArrayProps is not defined in v2.0.2
3 participants