Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed myriad bugs with moving field state #35

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Conversation

erikras
Copy link
Member

@erikras erikras commented Jul 17, 2019

Field state moving was all FUBAR. Looking better now.

Fixes #28.

@erikras erikras merged commit d0a198f into master Jul 17, 2019
@erikras erikras deleted the fix-field-state-moving branch July 17, 2019 12:39
@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #35   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     12    +1     
  Lines         147    139    -8     
  Branches       29     29           
=====================================
- Hits          147    139    -8
Impacted Files Coverage Δ
src/move.js 100% <100%> (ø) ⬆️
src/removeBatch.js 100% <100%> (ø) ⬆️
src/swap.js 100% <100%> (ø) ⬆️
src/moveFieldState.js 100% <100%> (ø)
src/insert.js 100% <100%> (ø) ⬆️
src/remove.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629a7c0...e1dfd22. Read the comment docs.

@erikras
Copy link
Member Author

erikras commented Jul 17, 2019

Published in v3.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field subscribers and validators is not updated when using move
1 participant