Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHVM fix - flush before exit #275

Merged
merged 1 commit into from
Mar 30, 2015
Merged

HHVM fix - flush before exit #275

merged 1 commit into from
Mar 30, 2015

Conversation

colin-kiegel
Copy link
Contributor

Whoops doesn't work for me with HHVM 3.6 due to a minor incompatibility between PHP and HHVM.

See facebook/hhvm#4055. The solution is to add flush() before exit(). IMO this workaround can be removed as soon as HHVM fixes this bug upstream in all their LTS releases.

@denis-sokolov
Copy link
Collaborator

That's cool, thank you.

denis-sokolov added a commit that referenced this pull request Mar 30, 2015
@denis-sokolov denis-sokolov merged commit c982fe6 into filp:master Mar 30, 2015
@colin-kiegel
Copy link
Contributor Author

Thx. It was a bit tough to spot - but at least that got me xdebug running with HHVM now! Yess! Bugs, here I come! ;-)

@colin-kiegel colin-kiegel deleted the hhvm-flush-before-exit branch March 30, 2015 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants