Add a cached data source to protect databases from health check volume #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I excluded stat replication and replication slots from the tests because we're probably going to remove those soon anyways.
schinns
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I excluded stat replication and replication slots from the tests because
we're probably going to remove those soon anyways.
When we wired this up to haproxy in prod we saw some db conn spikes. Did not impact db load but was making some connection charts look strange. This change will make it so we only perform a real db check once a second. Obviously caching a health check is a strange concept, but our health-checks run every 2 seconds so I think this is a safe change.
@benschinn