Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage dependency to homeassistant package #11

Open
marc-portier opened this issue Dec 10, 2021 · 2 comments
Open

manage dependency to homeassistant package #11

marc-portier opened this issue Dec 10, 2021 · 2 comments

Comments

@marc-portier
Copy link

This statement:

from homeassistant.components.climate import (

effectively adds a dependency to the "homeassistant" package.

If this is intentional, then requirements.txt should list this dependency.

marc-portier added a commit to marc-portier/nhc2-coco that referenced this issue Dec 10, 2021
@marc-portier
Copy link
Author

am not used to using the poetry tool - but probably the pyproject.toml needs to declare that dependency too ?

@marc-portier
Copy link
Author

getting deeper into the project I have the feeling more code-management stuff could/should be set up
see #12 for more on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant