-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift3 support #5
Conversation
Hey, I'd love to see this lib available in Swift 3 so I can implement it in my project. Thanks 😄 |
@tbaranes , sorry if I'm missing something obvious (I'm more familiar with objective C and just using this in an objective C project), but I copied and pasted your autocompleteField.swift to use with Xcode 8, and Xcode suggested to change some public to open, private to fileprivate, etc. .. may I suggest you make those changes here and commit? |
let words = self.text!.componentsSeparatedByString(" ") | ||
let suggestionWords = text.componentsSeparatedByString(" ") | ||
let words = self.text!.components(separatedBy: " ") | ||
let suggestionWords = self.text!.components(separatedBy: " ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should not have been changed from the original:
let suggestionWords = text.componentsSeparatedByString(" ")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, ok, it should be:
let suggestionWords = text.components(separatedBy: " ")
what I meant was, should be text, not self.text!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a typo in line 166 (see my comment below), otherwise it looks good
Since |
Close #4