feat(rate-limit): added 4s upstash service timeout #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Nov 17, 2022
|
Merged!!! Let's goooooo!!!! |
|
Show! E mais pra frente, no lugar dos 4s, a gente deveria levantar qual é o tempo normal que o Upstash leva para responder a maioria das requisições e colocar apenas uma pequena margem em cima disso. Assim não teremos praticamente nenhum impacto em caso de instabilidade no Upstash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devido ao limite de tempo de 5 segundos do middleware, esse PR cria um timeout e ignora o rate-limit se não houver uma resposta do Upstash dentro de 4 segundos.
Isso evita que a API do TabNews saia do ar em caso de problemas com o serviço Upstash, conforme conversado aqui.
Eu criei uma conta no Upstash para fazer os testes desse PR, mas fica como tarefa futura a criação de testes para o rate-limit.
Bora aumentar a resiliência do TabNews que o lançamento está quase aí 🚀