New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: Use documented NavigationView adaptive behavior and always set title bar #2628

Merged

yaira2 merged 1 commit into master from settings-titlebar

Dec 17, 2020

Contributor

lukeblevins commented Dec 17, 2020 •

edited by yaira2

Loading

Remove AdaptiveTrigger for window width in favor of using the PaneDisplayMode="Auto" setting with CompactModeThresholdWidth="0" for identical behavior
Fix bug where the titlebar (custom drag region) was only set when the Settings page is first created (fixes Can't drag the window when in Settings page #1498)


          Use documented NavigationView adaptive behavior and always set titlebar

69b6241

lukeblevins requested a review from yaira2

December 17, 2020 17:26

lukeblevins linked an issue

that may be closed by this pull request

Can't drag the window when in Settings page #1498

Closed

yaira2 approved these changes

View reviewed changes

yaira2 added the ready to merge label

yaira2 merged commit 73dba2b into master

yaira2 deleted the settings-titlebar branch

December 17, 2020 18:21

Member

yaira2 commented Dec 17, 2020

@duke7553 Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels