-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install updates from Files #2508
Conversation
@Thomas1664 Instead of adding a button to check for updates, it should autmaticly check for udpates when launching the app. |
I didn't want to implement it yet because if the code is wrong the app crashes |
That's fine, we will test it in a flight group to make sure it works correctly first, and if needed, we can wrap it in a try/catch. |
This comment has been minimized.
This comment has been minimized.
|
Yes |
Moved the check for updates to MainPage
How did you get around this? |
See the attached issue. We used a flight group. |
interesting. i've been struggling with this. I have a flight group also, but this still happens. |
@myokeeh We ended up wrapping this in a try/catch, for some reason we still get the error every time and updates are not detected, but at least the app isn't crashing. |
@yaichenbaum, so |
Fixes #1513
I implemented the feature to install updates via a button in the about settings page.