Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install updates from Files #2508

Merged
merged 13 commits into from
Dec 17, 2020
Merged

Install updates from Files #2508

merged 13 commits into from
Dec 17, 2020

Conversation

Thomas1664
Copy link
Contributor

Fixes #1513
I implemented the feature to install updates via a button in the about settings page.

@yaira2
Copy link
Member

yaira2 commented Dec 1, 2020

@Thomas1664 Instead of adding a button to check for updates, it should autmaticly check for udpates when launching the app.

@Thomas1664
Copy link
Contributor Author

I didn't want to implement it yet because if the code is wrong the app crashes

@yaira2
Copy link
Member

yaira2 commented Dec 1, 2020

I didn't want to implement it yet because if the code is wrong the app crashes

That's fine, we will test it in a flight group to make sure it works correctly first, and if needed, we can wrap it in a try/catch.

@ghost ghost added the needs - code review label Dec 1, 2020
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Dec 1, 2020
@JaiganeshKumaran

This comment has been minimized.

@yaira2 yaira2 self-requested a review December 6, 2020 15:58
Files/Views/SettingsPages/About.xaml Outdated Show resolved Hide resolved
@yaira2
Copy link
Member

yaira2 commented Dec 17, 2020

image
@Thomas1664 Is this because the app is not connected to the Store in our debug builds?

@Thomas1664
Copy link
Contributor Author

Yes

Moved the check for updates to MainPage
yaira2
yaira2 previously approved these changes Dec 17, 2020
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Dec 17, 2020
yaira2
yaira2 previously approved these changes Dec 17, 2020
@yaira2 yaira2 requested a review from tsvietOK December 17, 2020 16:49
@yaira2 yaira2 merged commit 4a337ba into files-community:master Dec 17, 2020
@myokeeh
Copy link

myokeeh commented Feb 13, 2021

Yes

How did you get around this?

@Thomas1664
Copy link
Contributor Author

Thomas1664 commented Feb 13, 2021

Yes

How did you get around this?

See the attached issue. We used a flight group.

@myokeeh
Copy link

myokeeh commented Feb 14, 2021

See the attached issue. We used a flight group.

interesting. i've been struggling with this. I have a flight group also, but this still happens.

@yaira2
Copy link
Member

yaira2 commented Feb 14, 2021

@myokeeh We ended up wrapping this in a try/catch, for some reason we still get the error every time and updates are not detected, but at least the app isn't crashing.

@myokeeh
Copy link

myokeeh commented Feb 14, 2021

@yaichenbaum, so GetAppAndOptionalStorePackageUpdatesAsync is in fact still broken--no updates detected. 🤷‍♂️I hope somebody at Microsoft gets on this and get it fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability of checking updates actively
6 participants