Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added Files icon to the process in Windows #16321

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

IviriusMain
Copy link
Contributor

@IviriusMain IviriusMain commented Oct 7, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files
  2. Open Task Manager
  3. The process now has an icon. NOTE: This icon is located at \src\Files.App\Logo.ico and it should always be replaced with the icon of the version launched to the public or as an insider build.

Why is this important?

In order for users to find Files more easily and be more comfortable with the app, the task should have an appropriate icon.

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please send a screenshot what the app looked/looks like in Task Manager.

src/Files.App/Logo.ico Outdated Show resolved Hide resolved
@IviriusMain
Copy link
Contributor Author

IviriusMain commented Oct 8, 2024

Above is the latest Insider build, below is the build in this pull request.

374348663-9c9e4524-7cb0-44c7-9e92-1da9fd6752a2.png

@yaira2 yaira2 changed the title Add essential task icon for Files Feature: Added Files icon to the process in Windows Oct 9, 2024
@yaira2 yaira2 requested a review from 0x5bfa October 9, 2024 14:01
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.
This is what I was doing when I tried to introduce Directory.Build.props

@yaira2
Copy link
Member

yaira2 commented Oct 9, 2024

@IviriusMain congrats on your first pull request! Thank you!

@yaira2 yaira2 merged commit 0e01986 into files-community:main Oct 9, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 9, 2024
@0x5bfa 0x5bfa mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: No task icon
3 participants